netdev - Re: [PATCH v1 net-next 4/7] tcp: Remove hashinfo test for inet6?_lookup_run_sk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANn89i+Wq+XiAK_HfgjO=gOesaXJvxT_FgAjstSCfAqzjwGrug@mail.gmail.com>
Date: Thu, 21 Aug 2025 00:00:20 -0700
From: Eric Dumazet <edumazet@...gle.com>
To: Kuniyuki Iwashima <kuniyu@...gle.com>
Cc: "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Neal Cardwell <ncardwell@...gle.com>, 
	David Ahern <dsahern@...nel.org>, Simon Horman <horms@...nel.org>, 
	Kuniyuki Iwashima <kuni1840@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v1 net-next 4/7] tcp: Remove hashinfo test for inet6?_lookup_run_sk_lookup().

On Wed, Aug 20, 2025 at 11:16 PM Kuniyuki Iwashima <kuniyu@...gle.com> wrote:

Please fix, and add

Reviewed-by: Eric Dumazet <edumazet@...gle.com>

>
> Commit 6c886db2e78c ("net: remove duplicate sk_lookup helpers")
> started to check if hashinfo == net->ipv4.tcp_death_row.hashinfo
> in __inet_lookup_listener() and inet6_lookup_listener() and
> stopped invoking BPF sk_lookup prog for DCCP.
>
> DCCP has gone and the condition is always true.
>
> Let's remove the hashinfo test.
>
> Signed-off-by: Kuniyuki Iwashima <kuniyu@...gle.com>
> ---