netdev - Re: [PATCH v1 10/14] regulator: dt-bindings: Convert Dialog Semiconductor DA9211 Regulators to YAML

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250821-practical-coyote-of-hail-d2fddb@kuoka>
Date: Thu, 21 Aug 2025 08:53:07 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Ariel D'Alessandro <ariel.dalessandro@...labora.com>
Cc: airlied@...il.com, amergnat@...libre.com, andrew+netdev@...n.ch, 
	andrew-ct.chen@...iatek.com, angelogioacchino.delregno@...labora.com, broonie@...nel.org, 
	chunkuang.hu@...nel.org, ck.hu@...iatek.com, conor+dt@...nel.org, davem@...emloft.net, 
	dmitry.torokhov@...il.com, edumazet@...gle.com, flora.fu@...iatek.com, 
	houlong.wei@...iatek.com, jeesw@...fas.com, jmassot@...labora.com, kernel@...labora.com, 
	krzk+dt@...nel.org, kuba@...nel.org, kyrie.wu@...iatek.corp-partner.google.com, 
	lgirdwood@...il.com, linus.walleij@...aro.org, louisalexis.eyraud@...labora.com, 
	maarten.lankhorst@...ux.intel.com, matthias.bgg@...il.com, mchehab@...nel.org, 
	minghsiu.tsai@...iatek.com, mripard@...nel.org, p.zabel@...gutronix.de, pabeni@...hat.com, 
	robh@...nel.org, sean.wang@...nel.org, simona@...ll.ch, 
	support.opensource@...semi.com, tiffany.lin@...iatek.com, tzimmermann@...e.de, 
	yunfei.dong@...iatek.com, devicetree@...r.kernel.org, dri-devel@...ts.freedesktop.org, 
	linux-arm-kernel@...ts.infradead.org, linux-clk@...r.kernel.org, linux-gpio@...r.kernel.org, 
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org, linux-media@...r.kernel.org, 
	linux-mediatek@...ts.infradead.org, linux-sound@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH v1 10/14] regulator: dt-bindings: Convert Dialog
 Semiconductor DA9211 Regulators to YAML

On Wed, Aug 20, 2025 at 02:12:58PM -0300, Ariel D'Alessandro wrote:
> Convert the existing text-based DT bindings for Dialog Semiconductor DA9211
> Voltage Regulators family to a YAML schema. Examples are simplified, as
> these are all equal.

Also not wrapped... fix your editor to recognize how commits are
written.

> 
> Signed-off-by: Ariel D'Alessandro <ariel.dalessandro@...labora.com>
> ---

...

> +---
> +$id: http://devicetree.org/schemas/regulator/dlg,da9211.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: |

Drop |

> +  Dialog Semiconductor DA9211/DA9212/DA9213/DA9223/DA9214/DA9224/DA9215/DA9225
> +  Voltage Regulator
> +
> +maintainers:
> +  - Ariel D'Alessandro <ariel.dalessandro@...labora.com>
> +
> +properties:
> +  compatible:
> +    enum:
> +      - "dlg,da9211"
> +      - "dlg,da9212"
> +      - "dlg,da9213"
> +      - "dlg,da9223"
> +      - "dlg,da9214"
> +      - "dlg,da9224"
> +      - "dlg,da9215"
> +      - "dlg,da9225"

No quotes. I don't think this was ever tested.

Also, keep it properly ordered


> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  regulators:
> +    type: object
> +    additionalProperties: false
> +    description: |

Drop |

> +      List of regulators provided by the device
> +
> +    patternProperties:
> +      "^BUCK([A-B])$":

[AB]

> +        type: object
> +        $ref: regulator.yaml#
> +        description: |
> +          Properties for a single BUCK regulator
> +
> +        properties:
> +          regulator-initial-mode:
> +            items:
> +              enum: [ 1, 2, 3 ]
> +            description: Defined in include/dt-bindings/regulator/dlg,da9211-regulator.h
> +
> +          regulator-allowed-modes:
> +            items:
> +              enum: [ 1, 2, 3 ]
> +            description: Defined in include/dt-bindings/regulator/dlg,da9211-regulator.h
> +
> +          enable-gpios:
> +            maxItems: 1
> +            description: Specify a valid GPIO for platform control of the regulator

Drop description, obvious.

> +
> +        unevaluatedProperties: false

For nested blocks this goes after $ref: regulator.

> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - regulators
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/regulator/dlg,da9211-regulator.h>
> +
> +    i2c1 {

i2c

> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        da9212: da9212@68 {

Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation


Best regards,
Krzysztof