netdev - Re: [PATCH net-next 1/2] net: maxlinear: Add build support for MxL SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <610db76b-7327-4331-888e-e538857c0887@lunn.ch>
Date: Fri, 22 Aug 2025 16:58:45 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Jack Ping CHNG <jchng@...linear.com>
Cc: netdev@...r.kernel.org, devicetree@...r.kernel.org, davem@...emloft.net,
	andrew+netdev@...n.ch, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, robh@...nel.org, krzk+dt@...nel.org,
	conor+dt@...nel.org, yzhu@...linear.com,
	sureshnagaraj@...linear.com
Subject: Re: [PATCH net-next 1/2] net: maxlinear: Add build support for MxL
 SoC

> +Driver Location
> +===============
> +
> +The driver source code is located in the kernel tree at:
> +  drivers/net/ethernet/maxlinear/
> +
> +Interfaces are created as standard Linux `net_device` interfaces:

Pointless comment. Anything else would be NACKed.

> +
> +- eth0, eth1 (up to 2)

This is also questionable. Yes, the kernel will give them names like
this, but systemd will then rename them.

> +- Multiqueue support (e.g., eth0 has multiple TX/RX queues)
> +
> +Kernel Configuration
> +====================
> +
> +The driver is located in the menu structure at:
> +
> +  -> Device Drivers
> +    -> Network device support
> +      -> Ethernet driver support
> +        -> MaxLinear NPU Ethernet driver
> +
> +Or set in your kernel config:
> +  CONFIG_NET_VENDOR_MAXLINEAR=y
> +  CONFIG_MAXLINEAR_ETH=y
> +
> +Maintainers
> +===========
> +
> +See the MAINTAINERS file:
> +
> +    MAXLINEAR ETHERNET DRIVER
> +    M: Jack Ping Chng <jchng@...linear.com>
> +    L: netdev@...r.kernel.org
> +    S: Supported
> +    F: drivers/net/ethernet/maxlinear/
> +
> diff --git a/MAINTAINERS b/MAINTAINERS
> index bce96dd254b8..9164ba07a9c3 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -15101,6 +15101,13 @@ W:	https://linuxtv.org
>  T:	git git://linuxtv.org/media.git
>  F:	drivers/media/radio/radio-maxiradio*
>  
> +MAXLINEAR ETHERNET DRIVER
> +M:	Jack Ping Chng <jchng@...linear.com>
> +L:	netdev@...r.kernel.org
> +S:	Maintained
> +F:	Documentation/networking/device_drivers/ethernet/maxlinear/*
> +F:	drivers/net/ethernet/maxlinear/
> +
>  MAXLINEAR ETHERNET PHY DRIVER
>  M:	Xu Liang <lxu@...linear.com>
>  L:	netdev@...r.kernel.org
> diff --git a/drivers/net/ethernet/Kconfig b/drivers/net/ethernet/Kconfig
> index f86d4557d8d7..94d0bb98351a 100644
> --- a/drivers/net/ethernet/Kconfig
> +++ b/drivers/net/ethernet/Kconfig
> @@ -33,6 +33,7 @@ source "drivers/net/ethernet/aquantia/Kconfig"
>  source "drivers/net/ethernet/arc/Kconfig"
>  source "drivers/net/ethernet/asix/Kconfig"
>  source "drivers/net/ethernet/atheros/Kconfig"
> +source "drivers/net/ethernet/maxlinear/Kconfig"

This file is sorted. Please insert in the correct location. Please
check all your other insertions.

> +
> +	snprintf(ndev->name, IFNAMSIZ, "eth%%d");

The core does that.

> +static int mxl_eth_probe(struct platform_device *pdev)
> +{
> +	struct mxl_eth_drvdata *pdata;

Historically, pdata has been used for platform_data. With the adoption
of DT, platform_data is not used much any more, but to greybeards like
me, i still read it as platform_data. More normal would be priv, or
maybe in this case drvdata, since the structure is called
mxl_eth_drvdata.

	Andrew