[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <d369e95f-7660-4771-8494-7cd83aa01906@lunn.ch>
Date: Fri, 22 Aug 2025 17:06:21 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Jack Ping CHNG <jchng@...linear.com>
Cc: netdev@...r.kernel.org, devicetree@...r.kernel.org, davem@...emloft.net,
andrew+netdev@...n.ch, edumazet@...gle.com, kuba@...nel.org,
pabeni@...hat.com, robh@...nel.org, krzk+dt@...nel.org,
conor+dt@...nel.org, yzhu@...linear.com,
sureshnagaraj@...linear.com
Subject: Re: [PATCH net-next 0/2] Add MxL Ethernet driver & devicetree binding
On Fri, Aug 22, 2025 at 05:08:07PM +0800, Jack Ping CHNG wrote:
> Hello netdev maintainers,
>
> This patch series adds support for the MaxLinear LGM SoC's Ethernet
> controller, including:
>
> Patch 1: Adds build infrastructure and the main driver for the MaxLinear LGM
> SoC Ethernet controller.
> Patch 2: Introduces the devicetree binding documentation for the MaxLinear LGM
> Network Processor.
>
> The driver supports multi-port operation and is integrated with standard Linux
> network device driver framework. The devicetree binding documents the required
> properties for the hardware description.
>
> Please review and let me know if any changes are required.
"if any changes are required"
ROFL. Have you ever seen a new network driver where v1 got accepted?
Anyway, thanks for starting small. But there is still a way to go
before this will be accepted.
FYI: DT patches go first in the series.
I suggest you subscribe to the netdev list, and spend 15-30 minutes a
day reading patches and reviews. You can learn a lot that way, and
avoid repeating mistakes others have made.
Andrew
---
pw-bot: cr
Powered by blists - more mailing lists