netdev - Re: [PATCH net] net: dsa: b53: fix ageing time for BCM53101

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a0e637f9-e612-4651-8b12-8cb82dd23c55@lunn.ch>
Date: Sat, 23 Aug 2025 17:31:52 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Jonas Gorski <jonas.gorski@...il.com>
Cc: Florian Fainelli <florian.fainelli@...adcom.com>,
	Vladimir Oltean <olteanv@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: dsa: b53: fix ageing time for BCM53101

On Sat, Aug 23, 2025 at 05:27:02PM +0200, Jonas Gorski wrote:
> Hi,
> 
> On Sat, Aug 23, 2025 at 5:00 PM Andrew Lunn <andrew@...n.ch> wrote:
> >
> > On Sat, Aug 23, 2025 at 11:06:16AM +0200, Jonas Gorski wrote:
> > > For some reason Broadcom decided that BCM53101 uses 0.5s increments for
> > > the ageing time register, but kept the field width the same [1]. Due to
> > > this, the actual ageing time was always half of what was configured.
> > >
> > > Fix this by adapting the limits and value calculation for BCM53101.
> > >
> > > [1] https://github.com/Broadcom-Network-Switching-Software/OpenMDK/blob/master/cdk/PKG/chip/bcm53101/bcm53101_a0_defs.h#L28966
> >
> > Is line 28966 correct? In order to find a reference to age, i needed
> > to search further in the file.
> 
> Hm, indeed, it's #30768. Not sure where that original line came from,
> maybe I miss-clicked before copying the link in the address bar.

Or a new version has been dumped there, changing all the line numbers?
I've not looked, is there a tag you can use instead of master?

> > Are these devices organised in families/generations. Are you sure this
> > does not apply to:
> >
> >         BCM53101_DEVICE_ID = 0x53101,
> 
> This is the chip for which I am fixing/changing it :)
> 
> >         BCM53115_DEVICE_ID = 0x53115,
> >         BCM53125_DEVICE_ID = 0x53125,
> >         BCM53128_DEVICE_ID = 0x53128,
> 
> Yes, pretty sure:
> 
> $ grep -l -r "Specifies the aging time in 0.5 seconds" cdk/PKG/chip | sort
> cdk/PKG/chip/bcm53101/bcm53101_a0_defs.h
> 
> $ grep -l -r "Specifies the aging time in seconds" cdk/PKG/chip | sort
> cdk/PKG/chip/bcm53010/bcm53010_a0_defs.h
> cdk/PKG/chip/bcm53020/bcm53020_a0_defs.h
> cdk/PKG/chip/bcm53084/bcm53084_a0_defs.h
> cdk/PKG/chip/bcm53115/bcm53115_a0_defs.h
> cdk/PKG/chip/bcm53118/bcm53118_a0_defs.h
> cdk/PKG/chip/bcm53125/bcm53125_a0_defs.h
> cdk/PKG/chip/bcm53128/bcm53128_a0_defs.h
> cdk/PKG/chip/bcm53134/bcm53134_a0_defs.h
> cdk/PKG/chip/bcm53242/bcm53242_a0_defs.h
> cdk/PKG/chip/bcm53262/bcm53262_a0_defs.h
> cdk/PKG/chip/bcm53280/bcm53280_a0_defs.h
> cdk/PKG/chip/bcm53280/bcm53280_b0_defs.h
> cdk/PKG/chip/bcm53600/bcm53600_a0_defs.h
> cdk/PKG/chip/bcm89500/bcm89500_a0_defs.h

Thanks. That is pretty convincing. Lets see if Florian has anything to
add.

	Andrew