netdev - Re: [PATCH v1 bpf-next/net 6/8] bpf: Introduce SK_BPF_MEMCG_FLAGS and SK_BPF_MEMCG_SOCK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202508232331.rxOqu50j-lkp@intel.com>
Date: Sat, 23 Aug 2025 23:38:06 +0800
From: kernel test robot <lkp@...el.com>
To: Kuniyuki Iwashima <kuniyu@...gle.com>,
	Alexei Starovoitov <ast@...nel.org>,
	Andrii Nakryiko <andrii@...nel.org>,
	Daniel Borkmann <daniel@...earbox.net>,
	Martin KaFai Lau <martin.lau@...ux.dev>
Cc: oe-kbuild-all@...ts.linux.dev,
	John Fastabend <john.fastabend@...il.com>,
	Stanislav Fomichev <sdf@...ichev.me>,
	Johannes Weiner <hannes@...xchg.org>,
	Michal Hocko <mhocko@...nel.org>,
	Roman Gushchin <roman.gushchin@...ux.dev>,
	Shakeel Butt <shakeel.butt@...ux.dev>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Neal Cardwell <ncardwell@...gle.com>,
	Willem de Bruijn <willemb@...gle.com>,
	Mina Almasry <almasrymina@...gle.com>,
	Kuniyuki Iwashima <kuniyu@...gle.com>, bpf@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH v1 bpf-next/net 6/8] bpf: Introduce SK_BPF_MEMCG_FLAGS
 and SK_BPF_MEMCG_SOCK_ISOLATED.

Hi Kuniyuki,

kernel test robot noticed the following build errors:

[auto build test ERROR on bpf-next/net]

url:    https://github.com/intel-lab-lkp/linux/commits/Kuniyuki-Iwashima/tcp-Save-lock_sock-for-memcg-in-inet_csk_accept/20250823-062322
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git net
patch link:    https://lore.kernel.org/r/20250822221846.744252-7-kuniyu%40google.com
patch subject: [PATCH v1 bpf-next/net 6/8] bpf: Introduce SK_BPF_MEMCG_FLAGS and SK_BPF_MEMCG_SOCK_ISOLATED.
config: arc-randconfig-002-20250823 (https://download.01.org/0day-ci/archive/20250823/202508232331.rxOqu50j-lkp@intel.com/config)
compiler: arc-linux-gcc (GCC) 12.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250823/202508232331.rxOqu50j-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202508232331.rxOqu50j-lkp@intel.com/

All errors (new ones prefixed by >>):

   net/core/filter.c: In function 'sk_bpf_set_get_memcg_flags':
>> net/core/filter.c:5290:9: error: implicit declaration of function 'mem_cgroup_sk_set_flags'; did you mean 'mem_cgroup_sk_get_flags'? [-Werror=implicit-function-declaration]
    5290 |         mem_cgroup_sk_set_flags(sk, *optval);
         |         ^~~~~~~~~~~~~~~~~~~~~~~
         |         mem_cgroup_sk_get_flags
   cc1: some warnings being treated as errors


vim +5290 net/core/filter.c

  5269	
  5270	static int sk_bpf_set_get_memcg_flags(struct sock *sk, int *optval, bool getopt)
  5271	{
  5272		if (!mem_cgroup_sk_enabled(sk))
  5273			return -EOPNOTSUPP;
  5274	
  5275		if (getopt) {
  5276			*optval = mem_cgroup_sk_get_flags(sk);
  5277			return 0;
  5278		}
  5279	
  5280		/* Don't allow once sk has been published to userspace.
  5281		 * INET_CREATE is called without lock_sock() but with sk_socket
  5282		 * INET_ACCEPT is called with lock_sock() but without sk_socket
  5283		 */
  5284		if (sock_owned_by_user_nocheck(sk) && sk->sk_socket)
  5285			return -EBUSY;
  5286	
  5287		if (*optval <= 0 || *optval >= SK_BPF_MEMCG_FLAG_MAX)
  5288			return -EINVAL;
  5289	
> 5290		mem_cgroup_sk_set_flags(sk, *optval);
  5291	
  5292		return 0;
  5293	}
  5294	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki