netdev - Re: [PATCH net-next v2 2/2] net: maxlinear: Add support for MxL LGM SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250826060918.1f6ffa3e@kernel.org>
Date: Tue, 26 Aug 2025 06:09:18 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Jack Ping CHNG <jchng@...linear.com>
Cc: <netdev@...r.kernel.org>, <devicetree@...r.kernel.org>,
 <davem@...emloft.net>, <andrew+netdev@...n.ch>, <edumazet@...gle.com>,
 <pabeni@...hat.com>, <robh@...nel.org>, <krzk+dt@...nel.org>,
 <conor+dt@...nel.org>, <yzhu@...linear.com>, <sureshnagaraj@...linear.com>
Subject: Re: [PATCH net-next v2 2/2] net: maxlinear: Add support for MxL LGM
 SoC

On Tue, 26 Aug 2025 11:10:44 +0800 Jack Ping CHNG wrote:
> +	for_each_available_child_of_node(pdev->dev.of_node, np) {
> +		if (!of_device_is_compatible(np, "mxl,eth-mac"))
> +			continue;
> +
> +		ret = mxl_eth_create_ndev(pdev, np, &ndev);
> +		if (ret)
> +			goto err_cleanup;
> +
> +		drvdata->ndevs[i++] = ndev;
> +		if (i >= MXL_NUM_PORT)
> +			break;
> +	}

You need a of_node_put(np) before the goto and the break;
-- 
pw-bot: cr