netdev - RE: [PATCH net-next v2 2/2] net: maxlinear: Add support for MxL LGM SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PH7PR19MB563654EF8D30DFE723775340B438A@PH7PR19MB5636.namprd19.prod.outlook.com>
Date: Wed, 27 Aug 2025 10:41:14 +0000
From: Jack Ping Chng <jchng@...linear.com>
To: Andrew Lunn <andrew@...n.ch>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"davem@...emloft.net" <davem@...emloft.net>, "andrew+netdev@...n.ch"
	<andrew+netdev@...n.ch>, "edumazet@...gle.com" <edumazet@...gle.com>,
	"kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"robh@...nel.org" <robh@...nel.org>, "krzk+dt@...nel.org"
	<krzk+dt@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>, Yi xin Zhu
	<yzhu@...linear.com>, Suresh Nagaraj <sureshnagaraj@...linear.com>
Subject: RE: [PATCH net-next v2 2/2] net: maxlinear: Add support for MxL LGM
 SoC

Hi Andrew,

On Tue, 26 Aug 2025 15:03:08 +0200
Andrew Lunn <andrew@...n.ch> wrote:

> > +     rst = devm_reset_control_get_optional(&pdev->dev, NULL);
> 
> Why is this optional? Are there some variants which don't have a
> reset?

Thanks for the review.
Will change to devm_reset_control_get()

> > +     i = 0;
> > +     for_each_available_child_of_node(pdev->dev.of_node, np) {
> > +             if (!of_device_is_compatible(np, "mxl,eth-mac"))
> > +                     continue;
> 
> Are there going to be other devices here, with different compatibles?

Yes, other devices will be added in the next patch series.

> > +
> > +             ret = mxl_eth_create_ndev(pdev, np, &ndev);
> 
> Shouldn't you validate reg before creating the device?

Will add of_address_to_resource()

Jack