netdev - Re: [PATCH net-next v2 2/2] net: maxlinear: Add support for MxL LGM SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b6a3eaa9-bb44-4ceb-aecb-af7f4125aa98@lunn.ch>
Date: Wed, 27 Aug 2025 14:16:37 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Jack Ping Chng <jchng@...linear.com>
Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"andrew+netdev@...n.ch" <andrew+netdev@...n.ch>,
	"edumazet@...gle.com" <edumazet@...gle.com>,
	"kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>,
	"robh@...nel.org" <robh@...nel.org>,
	"krzk+dt@...nel.org" <krzk+dt@...nel.org>,
	"conor+dt@...nel.org" <conor+dt@...nel.org>,
	Yi xin Zhu <yzhu@...linear.com>,
	Suresh Nagaraj <sureshnagaraj@...linear.com>
Subject: Re: [PATCH net-next v2 2/2] net: maxlinear: Add support for MxL LGM
 SoC

> > > +     i = 0;
> > > +     for_each_available_child_of_node(pdev->dev.of_node, np) {
> > > +             if (!of_device_is_compatible(np, "mxl,eth-mac"))
> > > +                     continue;
> > 
> > Are there going to be other devices here, with different compatibles?
> 
> Yes, other devices will be added in the next patch series.

DT describes the hardware. The hardware is not going to change, so you
might want to add the full DT binding now to describe it. That will
also help justify this compatible, which is a bit odd.

	Andrew