netdev - Re: [PATCH net-next v2 08/13] macsec: add NLA_POLICY_MAX for MACSEC_OFFLOAD_ATTR_TYPE and IFLA_MACSEC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aLBIUPQP_R972YXs@krikkit>
Date: Thu, 28 Aug 2025 14:15:12 +0200
From: Sabrina Dubroca <sd@...asysnail.net>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 08/13] macsec: add NLA_POLICY_MAX for
 MACSEC_OFFLOAD_ATTR_TYPE and IFLA_MACSEC_OFFLOAD

2025-08-27, 18:51:49 -0700, Jakub Kicinski wrote:
> On Tue, 26 Aug 2025 15:16:26 +0200 Sabrina Dubroca wrote:
> > This is equivalent to the existing checks allowing either
> > MACSEC_OFFLOAD_OFF or calling macsec_check_offload.
> 
> AFAICT "equivalent" is a bit misleading as we didn't have validation.
> But seems low risk.

We didn't have validation, but macsec_check_offload would return false
if offload was not one of {MACSEC_OFFLOAD_PHY,MACSEC_OFFLOAD_MAC}.
So I don't think this is adding any constraints compared to what we
already did.

-- 
Sabrina