netdev - Re: [PATCH net-next v3 1/2] net: phy: micrel: Introduce function __lan8814_ptp_probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250827174935.042bb768@kernel.org>
Date: Wed, 27 Aug 2025 17:49:35 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Horatiu Vultur <horatiu.vultur@...rochip.com>
Cc: <andrew@...n.ch>, <hkallweit1@...il.com>, <linux@...linux.org.uk>,
 <davem@...emloft.net>, <edumazet@...gle.com>, <pabeni@...hat.com>,
 <richardcochran@...il.com>, <Parthiban.Veerasooran@...rochip.com>,
 <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next v3 1/2] net: phy: micrel: Introduce function
 __lan8814_ptp_probe_once

On Tue, 26 Aug 2025 09:10:59 +0200 Horatiu Vultur wrote:
> -static int lan8814_ptp_probe_once(struct phy_device *phydev)
> +static int __lan8814_ptp_probe_once(struct phy_device *phydev, char *pin_name,
> +				    size_t gpios)

nit: size_t for gpios seems excessive, n_pins is an int. I'm guessing
you chose it based on kmalloc_array() arg type but, yeah, not sure it
makes sense within this context..