netdev - Re: [PATCH net-next v3 2/2] net: phy: micrel: Add PTP support for lan8842

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250828064332.n7kqn2rfuuieydnx@DEN-DL-M31836.microchip.com>
Date: Thu, 28 Aug 2025 08:43:32 +0200
From: Horatiu Vultur <horatiu.vultur@...rochip.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: <andrew@...n.ch>, <hkallweit1@...il.com>, <linux@...linux.org.uk>,
	<davem@...emloft.net>, <edumazet@...gle.com>, <pabeni@...hat.com>,
	<richardcochran@...il.com>, <Parthiban.Veerasooran@...rochip.com>,
	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next v3 2/2] net: phy: micrel: Add PTP support for
 lan8842

The 08/27/2025 17:47, Jakub Kicinski wrote:
> 
> On Tue, 26 Aug 2025 09:11:00 +0200 Horatiu Vultur wrote:
> > +#define LAN8842_STRAP_REG_PHYADDR_MASK               GENMASK(4, 0)
> 
> > +     addr = lanphy_read_page_reg(phydev, LAN8814_PAGE_COMMON_REGS,
> > +                                 LAN8842_STRAP_REG);
> > +     addr &= LAN8842_STRAP_REG_PHYADDR_MASK;
> > +     if (addr < 0)
> > +             return addr;
> 
> Did you mean to mask the value after the check if it's negative?

Yep, I wanted to mask after the check. I will fix this in the next
version.

-- 
/Horatiu