netdev - Re: [PATCH net] hsr: use netdev_master_upper_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250827180603.001b85b3@kernel.org>
Date: Wed, 27 Aug 2025 18:06:03 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Hangbin Liu <liuhangbin@...il.com>
Cc: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Simon
 Horman <horms@...nel.org>, Jakub Acs <acsjakub@...zon.de>, Sebastian
 Andrzej Siewior <bigeasy@...utronix.de>, Fernando Fernandez Mancera
 <ffmancera@...eup.net>, Taehee Yoo <ap420073@...il.com>
Subject: Re: [PATCH net] hsr: use netdev_master_upper_dev_link() when
 linking lower ports

On Tue, 26 Aug 2025 01:33:52 +0000 Hangbin Liu wrote:
> Unlike VLAN devices, HSR changes the lower device’s rx_handler, which
> prevents the lower device from being attached to another master.
> Switch to using netdev_master_upper_dev_link() when setting up the lower
> device.
> 
> This also improves user experience, since ip link will now display the
       ^^^^

Why this "also" here? You haven't mentioned any benefit of this change
up to this point. AFAIK having the master link is the only one?

> HSR device as the master for its ports.
> 
> Fixes: e0a4b99773d3 ("hsr: use upper/lower device infrastructure")

The current behavior is 5 years old, AFAICT. We need a reason to treat
this as a fix, right now this looks like net-next material..
-- 
pw-bot: cr