netdev - Re: [PATCH net] hsr: use netdev_master_upper_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aK_VQurV1-eQ0UJ9@fedora>
Date: Thu, 28 Aug 2025 04:04:18 +0000
From: Hangbin Liu <liuhangbin@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	Simon Horman <horms@...nel.org>, Jakub Acs <acsjakub@...zon.de>,
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
	Fernando Fernandez Mancera <ffmancera@...eup.net>,
	Taehee Yoo <ap420073@...il.com>
Subject: Re: [PATCH net] hsr: use netdev_master_upper_dev_link() when linking
 lower ports

On Wed, Aug 27, 2025 at 06:06:03PM -0700, Jakub Kicinski wrote:
> On Tue, 26 Aug 2025 01:33:52 +0000 Hangbin Liu wrote:
> > Unlike VLAN devices, HSR changes the lower device’s rx_handler, which
> > prevents the lower device from being attached to another master.
> > Switch to using netdev_master_upper_dev_link() when setting up the lower
> > device.
> > 
> > This also improves user experience, since ip link will now display the
>        ^^^^
> 
> Why this "also" here? You haven't mentioned any benefit of this change
> up to this point. AFAIK having the master link is the only one?

Apart from the "fix"(I thought), we can "also" benefit of the ip link output.

> 
> > HSR device as the master for its ports.
> > 
> > Fixes: e0a4b99773d3 ("hsr: use upper/lower device infrastructure")
> 
> The current behavior is 5 years old, AFAICT. We need a reason to treat
> this as a fix, right now this looks like net-next material..

If you think this is not a fix. Sure I can remove the "also" word and post to
net-next :)

Thanks
Hangbin