netdev - Re: [Intel-wired-lan] [PATCH iwl-net v3] i40e: fix Jumbo Frame support after iPXE boot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <888030bd-437e-4a40-8205-41417a8df7b6@intel.com>
Date: Thu, 28 Aug 2025 14:14:00 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: "Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>, Intel Wired LAN
	<intel-wired-lan@...ts.osuosl.org>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>
Subject: Re: [Intel-wired-lan] [PATCH iwl-net v3] i40e: fix Jumbo Frame
 support after iPXE boot



On 8/28/2025 5:22 AM, Loktionov, Aleksandr wrote:
> 
> 
>> -----Original Message-----
>> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf
>> Of Jacob Keller
>> Sent: Wednesday, August 27, 2025 11:18 PM
>> To: Intel Wired LAN <intel-wired-lan@...ts.osuosl.org>; Nguyen,
>> Anthony L <anthony.l.nguyen@...el.com>; netdev@...r.kernel.org
>> Cc: Keller, Jacob E <jacob.e.keller@...el.com>
>> Subject: [Intel-wired-lan] [PATCH iwl-net v3] i40e: fix Jumbo Frame
>> support after iPXE boot
>>
>> diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c
>> b/drivers/net/ethernet/intel/i40e/i40e_main.c
>> index b83f823e4917..4796fdd0b966 100644
>> --- a/drivers/net/ethernet/intel/i40e/i40e_main.c
>> +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
>> @@ -16045,13 +16045,18 @@ static int i40e_probe(struct pci_dev
>> *pdev, const struct pci_device_id *ent)
>>  		dev_dbg(&pf->pdev->dev, "get supported phy types ret =
>> %pe last_status =  %s\n",
>>  			ERR_PTR(err), libie_aq_str(pf-
>>> hw.aq.asq_last_status));
>>
>> -	/* make sure the MFS hasn't been set lower than the default
>> */
>>  #define MAX_FRAME_SIZE_DEFAULT 0x2600
> Can you consider re-name MAX_FRAME_SIZE_DEFAULT into I40E_MAX_FRAME_SIZE_DEFAULT ?
> 

We could. Its not in a header file so shouldn't pollute other files
which is why I originally opted to keep the name as-is.

>> -	val = FIELD_GET(I40E_PRTGL_SAH_MFS_MASK,
>> -			rd32(&pf->hw, I40E_PRTGL_SAH));
>> -	if (val < MAX_FRAME_SIZE_DEFAULT)
>> -		dev_warn(&pdev->dev, "MFS for port %x (%d) has been set
>> below the default (%d)\n",
>> -			 pf->hw.port, val, MAX_FRAME_SIZE_DEFAULT);
>> +
>> +	err = i40e_aq_set_mac_config(hw, MAX_FRAME_SIZE_DEFAULT,
>> NULL);
> Are you sure it's safe to use hw var here? Because old code used pf->hw.
> 

Yes. I don't know why the original code used pf->hw, but we have a local
hw variable which points to the proper address already in this function.

>> +	if (err) {
>> +		dev_warn(&pdev->dev, "set mac config ret =  %pe
>> last_status =  %s\n",
>> +			 ERR_PTR(err), libie_aq_str(pf-
>>> hw.aq.asq_last_status));
>> +	}
>> +
>> +	/* Make sure the MFS is set to the expected value */
>> +	val = rd32(hw, I40E_PRTGL_SAH);
>> +	FIELD_MODIFY(I40E_PRTGL_SAH_MFS_MASK, &val,
>> MAX_FRAME_SIZE_DEFAULT);
>> +	wr32(hw, I40E_PRTGL_SAH, val);
>>
>>  	/* Add a filter to drop all Flow control frames from any VSI
>> from being
>>  	 * transmitted. By doing so we stop a malicious VF from
>> sending out
>>
>> ---
>> base-commit: ceb9515524046252c522b16f38881e8837ec0d91
>> change-id: 20250813-jk-fix-i40e-ice-pxe-9k-mtu-2b6d03621cd9
>>
>> Best regards,
>> --
>> Jacob Keller <jacob.e.keller@...el.com>
> 
> Signed-off-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>
> 
> 



Download attachment "OpenPGP_signature.asc" of type "application/pgp-signature" (237 bytes)