netdev - Re: [PATCH net-next] bnxt_en: fix incorrect page count in RX aggr ring log

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f16a9977-b047-4841-8a31-5a39778a6655@intel.com>
Date: Thu, 28 Aug 2025 14:38:29 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Alok Tiwari <alok.a.tiwari@...cle.com>, <michael.chan@...adcom.com>,
	<pavan.chebbi@...adcom.com>, <andrew+netdev@...n.ch>, <davem@...emloft.net>,
	<edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>,
	<horms@...nel.org>, <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] bnxt_en: fix incorrect page count in RX aggr
 ring log



On 8/28/2025 12:48 PM, Alok Tiwari wrote:
> The warning in bnxt_alloc_one_rx_ring_netmem() reports the number
> of pages allocated for the RX aggregation ring. However, it
> mistakenly used bp->rx_ring_size instead of bp->rx_agg_ring_size,
> leading to confusing or misleading log output.
> 
> Use the correct bp->rx_agg_ring_size value to fix this.
> 
> Signed-off-by: Alok Tiwari <alok.a.tiwari@...cle.com>
> ---

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>

>  drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> index 207a8bb36ae5..0d30abadf06c 100644
> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> @@ -4397,7 +4397,7 @@ static void bnxt_alloc_one_rx_ring_netmem(struct bnxt *bp,
>  	for (i = 0; i < bp->rx_agg_ring_size; i++) {
>  		if (bnxt_alloc_rx_netmem(bp, rxr, prod, GFP_KERNEL)) {
>  			netdev_warn(bp->dev, "init'ed rx ring %d with %d/%d pages only\n",
> -				    ring_nr, i, bp->rx_ring_size);
> +				    ring_nr, i, bp->rx_agg_ring_size);
>  			break;
>  		}
>  		prod = NEXT_RX_AGG(prod);



Download attachment "OpenPGP_signature.asc" of type "application/pgp-signature" (237 bytes)