netdev - Re: [PATCH ipsec] xfrm: xfrm_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250829134931.GL31759@horms.kernel.org>
Date: Fri, 29 Aug 2025 14:49:31 +0100
From: Simon Horman <horms@...nel.org>
To: Sabrina Dubroca <sd@...asysnail.net>
Cc: netdev@...r.kernel.org, Aakash Kumar S <saakashkumar@...vell.com>,
	steffen.klassert@...unet.com, herbert@...dor.apana.org.au,
	syzbot+a25ee9d20d31e483ba7b@...kaller.appspotmail.com
Subject: Re: [PATCH ipsec] xfrm: xfrm_alloc_spi shouldn't use 0 as SPI

On Fri, Aug 29, 2025 at 10:54:15AM +0200, Sabrina Dubroca wrote:
> x->id.spi == 0 means "no SPI assigned", but since commit
> 94f39804d891 ("xfrm: Duplicate SPI Handling"), we now create states
> and add them to the byspi list with this value.
> 
> __xfrm_state_delete doesn't remove those states from the byspi list,
> since they shouldn't be there, and this shows up as a UAF the next
> time we go through the byspi list.
> 
> Reported-by: syzbot+a25ee9d20d31e483ba7b@...kaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=a25ee9d20d31e483ba7b
> Fixes: 94f39804d891 ("xfrm: Duplicate SPI Handling")
> Signed-off-by: Sabrina Dubroca <sd@...asysnail.net>

Thanks, I see that prior to the cited commit an error would
be returned if newspi was 0. Where newspi was
assigned the value of get_random_u32_inclusive(low, high).

Reviewed-by: Simon Horman <horms@...nel.org>

...