[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <aLfeXFePeKjLPwaN@secunet.com>
Date: Wed, 3 Sep 2025 08:21:16 +0200
From: Steffen Klassert <steffen.klassert@...unet.com>
To: Sabrina Dubroca <sd@...asysnail.net>
CC: <netdev@...r.kernel.org>, Aakash Kumar S <saakashkumar@...vell.com>,
<herbert@...dor.apana.org.au>,
<syzbot+a25ee9d20d31e483ba7b@...kaller.appspotmail.com>
Subject: Re: [PATCH ipsec] xfrm: xfrm_alloc_spi shouldn't use 0 as SPI
On Fri, Aug 29, 2025 at 10:54:15AM +0200, Sabrina Dubroca wrote:
> x->id.spi == 0 means "no SPI assigned", but since commit
> 94f39804d891 ("xfrm: Duplicate SPI Handling"), we now create states
> and add them to the byspi list with this value.
>
> __xfrm_state_delete doesn't remove those states from the byspi list,
> since they shouldn't be there, and this shows up as a UAF the next
> time we go through the byspi list.
>
> Reported-by: syzbot+a25ee9d20d31e483ba7b@...kaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=a25ee9d20d31e483ba7b
> Fixes: 94f39804d891 ("xfrm: Duplicate SPI Handling")
> Signed-off-by: Sabrina Dubroca <sd@...asysnail.net>
Applied, thanks a lot Sabrina!
Powered by blists - more mailing lists