netdev - Re: [PATCH net-next v2 10/14] net: add helper to pre-check if PP for an Rx queue will be unreadable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHS8izMh4O+U1p84TnxS2cLhyyG=gMy_yo0U09x=NYYzEHYe-A@mail.gmail.com>
Date: Fri, 29 Aug 2025 14:56:06 -0700
From: Mina Almasry <almasrymina@...gle.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com, 
	pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org, tariqt@...dia.com, 
	dtatulea@...dia.com, hawk@...nel.org, ilias.apalodimas@...aro.org, 
	alexanderduyck@...com, sdf@...ichev.me
Subject: Re: [PATCH net-next v2 10/14] net: add helper to pre-check if PP for
 an Rx queue will be unreadable

On Thu, Aug 28, 2025 at 6:23 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> mlx5 pokes into the rxq state to check if the queue has a memory
> provider, and therefore whether it may produce unreadable mem.
> Add a helper for doing this in the page pool API. fbnic will want
> a similar thing (tho, for a slightly different reason).
>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Mina Almasry <almasrymina@...gle.com>

Only thing is I wonder if we need to ASSERT_RTNL (or the netdev
instance lock equivalent) in the helper to catch data races around
setting/querying mp_ops in future code, but we already don't do that
in existing code and it's not worth the hassle.

-- 
Thanks,
Mina