netdev - Re: [PATCH net-next v2 12/14] eth: fbnic: defer page pool recycling activation to queue start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHS8izPgBw++BGnfJsR3eAsnOvp=N8sov3hPsYgcsdGdo+0vcw@mail.gmail.com>
Date: Fri, 29 Aug 2025 14:57:15 -0700
From: Mina Almasry <almasrymina@...gle.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com, 
	pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org, tariqt@...dia.com, 
	dtatulea@...dia.com, hawk@...nel.org, ilias.apalodimas@...aro.org, 
	alexanderduyck@...com, sdf@...ichev.me
Subject: Re: [PATCH net-next v2 12/14] eth: fbnic: defer page pool recycling
 activation to queue start

On Thu, Aug 28, 2025 at 6:23 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> We need to be more careful about when direct page pool recycling
> is enabled in preparation for queue ops support. Don't set the
> NAPI pointer, call page_pool_enable_direct_recycling() from
> the function that activates the queue (once the config can
> no longer fail).
>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Mina Almasry <almasrymina@...gle.com>

-- 
Thanks,
Mina