netdev - Re: [PATCH net-next v2 14/14] eth: fbnic: support queue ops / zero-copy Rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHS8izMevLVzi8JdZ4YPNkvEJB4WLcnEius25MME60NP1KSN1A@mail.gmail.com>
Date: Fri, 29 Aug 2025 15:09:06 -0700
From: Mina Almasry <almasrymina@...gle.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com, 
	pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org, tariqt@...dia.com, 
	dtatulea@...dia.com, hawk@...nel.org, ilias.apalodimas@...aro.org, 
	alexanderduyck@...com, sdf@...ichev.me
Subject: Re: [PATCH net-next v2 14/14] eth: fbnic: support queue ops /
 zero-copy Rx

On Thu, Aug 28, 2025 at 6:23 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> Support queue ops. fbnic doesn't shut down the entire device
> just to restart a single queue.
>
>   ./tools/testing/selftests/drivers/net/hw/iou-zcrx.py
>   TAP version 13
>   1..3
>   ok 1 iou-zcrx.test_zcrx
>   ok 2 iou-zcrx.test_zcrx_oneshot
>   ok 3 iou-zcrx.test_zcrx_rss
>   # Totals: pass:3 fail:0 xfail:0 xpass:0 skip:0 error:0
>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

I don't have deep understanding of the internals of the driver but
from queue API interface POV I don't see any issues. FWIW:

Acked-by: Mina Almasry <almasrymina@...gle.com>

-- 
Thanks,
Mina