[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250901-angelic-righteous-chipmunk-843fac@kuoka>
Date: Mon, 1 Sep 2025 06:59:01 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Jack Ping CHNG <jchng@...linear.com>
Cc: netdev@...r.kernel.org, devicetree@...r.kernel.org,
davem@...emloft.net, andrew+netdev@...n.ch, edumazet@...gle.com, kuba@...nel.org,
pabeni@...hat.com, robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
yzhu@...linear.com, sureshnagaraj@...linear.com
Subject: Re: [PATCH net-next v3 1/2] dt-bindings: net: mxl: Add MxL LGM
Network Processor SoC
On Fri, Aug 29, 2025 at 08:48:42PM +0800, Jack Ping CHNG wrote:
> +title: MaxLinear LGM Ethernet Controller
> +
> +maintainers:
> + - Jack Ping Chng <jchng@...linear.com>
> +
> +description:
> + Binding for MaxLinear LGM Ethernet controller
Drop "Binding for" and write proper description of hardware, not what
binding is for.
What is LGM? What is LGM SoC? Why there is nowhere anything about that
LGM SoC?
> +
> +properties:
> + compatible:
> + enum:
> + - maxlinear,lgm-eth
> +
> + reg:
> + maxItems: 2
> +
> + reg-names:
> + items:
> + - const: port
> + - const: ctrl
> +
> + clocks:
> + maxItems: 1
> +
> + clock-names:
> + items:
> + - const: ethif
> +
> + resets:
> + maxItems: 1
> +
> + ethernet-ports:
> + type: object
> + additionalProperties: false
> +
> + properties:
> + "#address-cells":
> + const: 1
> +
> + "#size-cells":
> + const: 0
> +
> + patternProperties:
> + "^port@[0-3]$":
> + type: object
> + $ref: ethernet-controller.yaml#
> + additionalProperties: false
> +
> + properties:
> + reg:
> + description: port id
> + maxItems: 1
> +
> + phy-handle:
> + maxItems: 1
> +
> + required:
> + - reg
> + - phy-handle
> +
> + mdio:
> + $ref: mdio.yaml#
> + unevaluatedProperties: false
> +
> +additionalProperties: false
Why did you move this? Previous position was correct, after required:.
> +
> +required:
> + - compatible
> + - reg
> + - reg-names
> + - clocks
> + - clock-names
> + - resets
> + - mdio
> +
> +examples:
> + - |
> + ethernet@...40000 {
> + compatible = "maxlinear,lgm-eth";
> + reg = <0xe7140000 0x1200>,<0xe7150000 0x4000>;
Missing space after ,
> + reg-names = "port", "ctrl";
> + clocks = <&cgu0 32>;
> + clock-names = "ethif";
> + resets = <&rcu0 0x70 8>;
Best regards,
Krzysztof
Powered by blists - more mailing lists