netdev - Re: [PATCH 2/3] selftests: drv-net: Fix tolerance calculation in devlink_rate_tc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250901154557.GI15473@horms.kernel.org>
Date: Mon, 1 Sep 2025 16:45:57 +0100
From: Simon Horman <horms@...nel.org>
To: Carolina Jubran <cjubran@...dia.com>
Cc: Shuah Khan <shuah@...nel.org>, Andrew Lunn <andrew+netdev@...n.ch>,
	"David S . Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Gal Pressman <gal@...dia.com>, Tariq Toukan <tariqt@...dia.com>,
	Cosmin Ratiu <cratiu@...dia.com>, Nimrod Oren <noren@...dia.com>,
	Mark Bloch <mbloch@...dia.com>, linux-kernel@...r.kernel.org,
	linux-kselftest@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH 2/3] selftests: drv-net: Fix tolerance calculation in
 devlink_rate_tc_bw.py

On Sun, Aug 31, 2025 at 11:06:40AM +0300, Carolina Jubran wrote:
> Currently, tolerance is computed against the TC’s expected percentage,
> making TC3 (20%) validation overly strict and TC4 (80%) overly loose.
> 
> Update BandwidthValidator to take a dict of shares and compute bounds
> relative to the overall total, so that all shares are validated
> consistently.
> 
> Fixes: 23ca32e4ead4 ("selftests: drv-net: Add test for devlink-rate traffic class bandwidth distribution")
> Tested-by: Carolina Jubran <cjubran@...dia.com>
> Signed-off-by: Carolina Jubran <cjubran@...dia.com>
> Reviewed-by: Cosmin Ratiu <cratiu@...dia.com>
> Reviewed-by: Nimrod Oren <noren@...dia.com>

Reviewed-by: Simon Horman <horms@...nel.org>