netdev - Re: [PATCH 3/3] selftests: drv-net: Relax total BW check in devlink_rate_tc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250901154609.GJ15473@horms.kernel.org>
Date: Mon, 1 Sep 2025 16:46:09 +0100
From: Simon Horman <horms@...nel.org>
To: Carolina Jubran <cjubran@...dia.com>
Cc: Shuah Khan <shuah@...nel.org>, Andrew Lunn <andrew+netdev@...n.ch>,
	"David S . Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Gal Pressman <gal@...dia.com>, Tariq Toukan <tariqt@...dia.com>,
	Cosmin Ratiu <cratiu@...dia.com>, Nimrod Oren <noren@...dia.com>,
	Mark Bloch <mbloch@...dia.com>, linux-kernel@...r.kernel.org,
	linux-kselftest@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH 3/3] selftests: drv-net: Relax total BW check in
 devlink_rate_tc_bw.py

On Sun, Aug 31, 2025 at 11:06:41AM +0300, Carolina Jubran wrote:
> This test is meant to check TC bandwidth distribution, not the tx_max
> of the VF. The total bandwidth check is only there to make sure that FW
> tokens limit traffic, because the per-TC share is only meaningful when
> the link is fully saturated.
> 
> Because the measured total is the sum of two iperf3 streams that do not
> always start or stop at the same time, using a strict 1 Gbps target
> caused random failures. This change adds a tolerance parameter to
> BandwidthValidator, keeps per-TC checks tight at +-12%, and relaxes the
> total bandwidth check to +-25% around 1 Gbps.
> 
> This avoids false failures while still confirming that the TC share
> validation is meaningful.
> 
> Fixes: 23ca32e4ead4 ("selftests: drv-net: Add test for devlink-rate traffic class bandwidth distribution")
> Tested-by: Carolina Jubran <cjubran@...dia.com>
> Signed-off-by: Carolina Jubran <cjubran@...dia.com>
> Reviewed-by: Cosmin Ratiu <cratiu@...dia.com>
> Reviewed-by: Nimrod Oren <noren@...dia.com>

Reviewed-by: Simon Horman <horms@...nel.org>