netdev - Re: [PATCH iwl-next v2 1/3] ice: remove legacy Rx and construct SKB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aLhmvbZ_XXEFzNxW@localhost.localdomain>
Date: Wed, 3 Sep 2025 18:03:09 +0200
From: Michal Kubiak <michal.kubiak@...el.com>
To: Alexander Lobakin <aleksander.lobakin@...el.com>
CC: <intel-wired-lan@...ts.osuosl.org>, <maciej.fijalkowski@...el.com>,
	<jacob.e.keller@...el.com>, <larysa.zaremba@...el.com>,
	<netdev@...r.kernel.org>, <przemyslaw.kitszel@...el.com>,
	<pmenzel@...gen.mpg.de>, <anthony.l.nguyen@...el.com>
Subject: Re: [PATCH iwl-next v2 1/3] ice: remove legacy Rx and construct SKB

On Wed, Sep 03, 2025 at 05:09:41PM +0200, Alexander Lobakin wrote:
> From: Michal Kubiak <michal.kubiak@...el.com>
> Date: Fri, 8 Aug 2025 17:56:57 +0200
> 
> > The commit 53844673d555 ("iavf: kill 'legacy-rx' for good") removed
> > the legacy Rx path in the iavf driver. This change applies the same
> > rationale to the ice driver.
> 
> BTW you forgot to remove `ICE_RX_FLAGS_RING_BUILD_SKB` from ice_txrx.h
> and the corresponding inlines (now unused).
> 
> Thanks,
> Olek

Yeah, it makes sense. Thanks for reporting that.
I will most likely need to send out v3, as Larysa has identified a potentially
even more serious issue related to XDP_TX.
Therefore, I will remove the flag in v3.

Tony, please hold off on preparing the final pull request for this series
until further notice.

Thanks,
Michal