netdev - Re: [PATCH net-next] selftests: net: Add tests to verify team driver option set and get.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aLjlLl03-YJ_avaa@fedora>
Date: Thu, 4 Sep 2025 01:02:38 +0000
From: Hangbin Liu <liuhangbin@...il.com>
To: Marc Harvey <marcharvey@...gle.com>
Cc: jiri@...nulli.us, andrew+netdev@...n.ch, edumazet@...gle.com,
	willemb@...gle.com, maheshb@...gle.com, netdev@...r.kernel.org,
	linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net-next] selftests: net: Add tests to verify team driver
 option set and get.

On Tue, Sep 02, 2025 at 11:55:04PM +0000, Marc Harvey wrote:
> There are currently no kernel tests that verify setting and getting
> options of the team driver.
> 
> In the future, options may be added that implicitly change other
> options, which will make it useful to have tests like these that show
> nothing breaks. There will be a follow up patch to this that adds new
> "rx_enabled" and "tx_enabled" options, which will implicitly affect the
> "enabled" option value and vice versa.
> 
> The tests use teamnl to first set options to specific values and then
> gets them to compare to the set values.
> 
> Signed-off-by: Marc Harvey <marcharvey@...gle.com>
> ---
>  .../selftests/drivers/net/team/Makefile       |   6 +-
>  .../selftests/drivers/net/team/options.sh     | 194 ++++++++++++++++++
>  2 files changed, 198 insertions(+), 2 deletions(-)
>  create mode 100755 tools/testing/selftests/drivers/net/team/options.sh
> 
> diff --git a/tools/testing/selftests/drivers/net/team/Makefile b/tools/testing/selftests/drivers/net/team/Makefile
> index eaf6938f100e..8b00b70ce67f 100644
> --- a/tools/testing/selftests/drivers/net/team/Makefile
> +++ b/tools/testing/selftests/drivers/net/team/Makefile
> @@ -1,11 +1,13 @@
>  # SPDX-License-Identifier: GPL-2.0
>  # Makefile for net selftests
>  
> -TEST_PROGS := dev_addr_lists.sh propagation.sh
> +TEST_PROGS := dev_addr_lists.sh propagation.sh options.sh
>  
>  TEST_INCLUDES := \
>  	../bonding/lag_lib.sh \
>  	../../../net/forwarding/lib.sh \
> -	../../../net/lib.sh
> +	../../../net/lib.sh \
> +	../../../net/in_netns.sh \

I didn't find you use namespace for testing, so why include the in_netns.sh ?
BTW, It's recommended to use namespace for testing to avoid affect the main
net.

Thanks
Hangbin