netdev - Re: [PATCHv2 net-next 2/2] net: lan966x: convert fwnode to of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKxU2N_RaPLj07ZqxtefPUJCnRbThZjKhpqfpey9QB2g3kNfsw@mail.gmail.com>
Date: Wed, 3 Sep 2025 18:04:42 -0700
From: Rosen Penev <rosenp@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, Horatiu Vultur <horatiu.vultur@...rochip.com>, 
	"maintainer:MICROCHIP LAN966X ETHERNET DRIVER" <UNGLinuxDriver@...rochip.com>, Andrew Lunn <andrew+netdev@...n.ch>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Paolo Abeni <pabeni@...hat.com>, Russell King <linux@...linux.org.uk>
Subject: Re: [PATCHv2 net-next 2/2] net: lan966x: convert fwnode to of

On Wed, Sep 3, 2025 at 4:55 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Mon,  1 Sep 2025 13:20:01 -0700 Rosen Penev wrote:
> > This is a purely OF driver. There's no need for fwnode to handle any of
> > this, with the exception being phylik_create. Use of_fwnode_handle for
> > that.
>
> Not sure this is worth cleaning up, but I'm not an OF API expert.
> It's pretty odd that you're sneaking in an extra error check in
> such a cleanup patch without even mentioning it.
git grep shows most drivers handling the error.

git grep of_get_phy_mode drivers/ | grep -v = | wc -l
7
git grep \ =\ of_get_phy_mode drivers/ | wc -l
48

I don't see why it should be different here.

Actually without handling the error, phy_mode gets used unassigned in
lan966x_probe_port

The fwnode API is different as it conflates int and phy_connection_t
as the same thing.
> --
> pw-bot: cr