[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20250904091334.53965-1-wahrenst@gmx.net>
Date: Thu, 4 Sep 2025 11:13:34 +0200
From: Stefan Wahren <wahrenst@....net>
To: Wei Fang <wei.fang@....com>,
Shenwei Wang <shenwei.wang@....com>,
Clark Wang <xiaoning.wang@....com>,
Andrew Lunn <andrew+netdev@...n.ch>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>
Cc: imx@...ts.linux.dev,
netdev@...r.kernel.org,
Stefan Wahren <wahrenst@....net>,
Christoph Niedermaier <cniedermaier@...electronics.com>,
Richard Leitner <richard.leitner@...data.com>
Subject: [PATCH net] net: fec: Fix possible NPD in fec_enet_phy_reset_after_clk_enable()
The function of_phy_find_device may return NULL, so we need to take
care before dereferencing phy_dev.
Fixes: 64a632da538a ("net: fec: Fix phy_device lookup for phy_reset_after_clk_enable()")
Signed-off-by: Stefan Wahren <wahrenst@....net>
Cc: Christoph Niedermaier <cniedermaier@...electronics.com>
Cc: Richard Leitner <richard.leitner@...data.com>
---
drivers/net/ethernet/freescale/fec_main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
index 1383918f8a3f..adf1f2bbcbb1 100644
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -2363,7 +2363,8 @@ static void fec_enet_phy_reset_after_clk_enable(struct net_device *ndev)
*/
phy_dev = of_phy_find_device(fep->phy_node);
phy_reset_after_clk_enable(phy_dev);
- put_device(&phy_dev->mdio.dev);
+ if (phy_dev)
+ put_device(&phy_dev->mdio.dev);
}
}
--
2.34.1
Powered by blists - more mailing lists