netdev - Re: [PATCH net] net: fec: Fix possible NPD in fec_enet_phy_reset_after_clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250904065836.5d0f4486@kernel.org>
Date: Thu, 4 Sep 2025 06:58:36 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Stefan Wahren <wahrenst@....net>
Cc: Wei Fang <wei.fang@....com>, Shenwei Wang <shenwei.wang@....com>, Clark
 Wang <xiaoning.wang@....com>, Andrew Lunn <andrew+netdev@...n.ch>, "David
 S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo
 Abeni <pabeni@...hat.com>, imx@...ts.linux.dev, netdev@...r.kernel.org,
 Christoph Niedermaier <cniedermaier@...electronics.com>, Richard Leitner
 <richard.leitner@...data.com>
Subject: Re: [PATCH net] net: fec: Fix possible NPD in
 fec_enet_phy_reset_after_clk_enable()

On Thu,  4 Sep 2025 11:13:34 +0200 Stefan Wahren wrote:
>  		phy_dev = of_phy_find_device(fep->phy_node);
>  		phy_reset_after_clk_enable(phy_dev);
> -		put_device(&phy_dev->mdio.dev);
> +		if (phy_dev)
> +			put_device(&phy_dev->mdio.dev);

Looks correct, but isn't it better to also wrap
phy_reset_after_clk_enable() with the if()?
Up to you..