netdev - Re: [PATCH net 1/3] netlink: specs: mptcp: fix if-idx attribute type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <704358b3-22c9-42d2-b7d7-08f435b2991f@kernel.org>
Date: Wed, 10 Sep 2025 10:27:44 +0200
From: Matthieu Baerts <matttbe@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Donald Hunter <donald.hunter@...il.com>,
 Mat Martineau <martineau@...nel.org>, Geliang Tang <geliang@...nel.org>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>,
 Davide Caratti <dcaratti@...hat.com>, Jonathan Corbet <corbet@....net>,
 Shuah Khan <shuah@...nel.org>, netdev@...r.kernel.org,
 mptcp@...ts.linux.dev, linux-kernel@...r.kernel.org,
 linux-doc@...r.kernel.org, linux-kselftest@...r.kernel.org,
 stable@...r.kernel.org
Subject: Re: [PATCH net 1/3] netlink: specs: mptcp: fix if-idx attribute type

Hi Jakub,

On 10/09/2025 03:42, Jakub Kicinski wrote:
> On Tue, 9 Sep 2025 11:08:46 +0200 Matthieu Baerts wrote:
>>> Note that mptcp_pm_parse_entry has this, which should maybe be fixed at
>>> the same time:
>>>
>>> 	u32 val = nla_get_s32(tb[MPTCP_PM_ADDR_ATTR_IF_IDX]);  
>>
>> Good catch!
> 
> indeed!
> 
>> This should be fixed in a dedicated patch, because this fixes commit:
>> ef0da3b8a2f1 ("mptcp: move address attribute into mptcp_addr_info"), a
>> different commit than the one being fixed here.
> 
> int = u32 is unlikely to cause issues AFAIU. We recently applied 
> a bunch of such fixes to net-next. I think this can also go to -next.

Good point, in our tree, I will queue this patch for -next:

https://lore.kernel.org/20250909-mptcp-pm-user-c-flag-v2-1-a6f9542481c5@kernel.org

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.