netdev - Re: [PATCH net 2/7] selftests: can: enable CONFIG_CAN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aME2mCZRagWbhhiG@dcaratti.users.ipa.redhat.com>
Date: Wed, 10 Sep 2025 10:28:08 +0200
From: Davide Caratti <dcaratti@...hat.com>
To: Ilya Maximets <i.maximets@....org>
Cc: Marc Kleine-Budde <mkl@...gutronix.de>, netdev@...r.kernel.org,
	davem@...emloft.net, kuba@...nel.org, linux-can@...r.kernel.org,
	kernel@...gutronix.de, Vincent Mailhol <mailhol@...nel.org>
Subject: Re: [PATCH net 2/7] selftests: can: enable CONFIG_CAN_VCAN as a
 module

hi,

On Wed, Sep 10, 2025 at 09:37:59AM +0200, Davide Caratti wrote:
> > ...
> > # 4.13 [+0.00] # Exception| lib.py.utils.CmdExitFailure: Command failed:
> >         ['ip', '-netns', 'rhsbrszn', 'link', 'add', 'foo', 'type', 'vxcan']
> > # 4.14 [+0.00] # Exception| STDERR: b'Error: Unknown device type.\n'
> > 
> 
> > Best regards, Ilya Maximets.
> 
> thanks for spotting this, I was testing the patch with:
> 
>  # vng --kconfig
>  # yes | make kselftest-merge
>  # grep ^CONFIG_CAN .config
> 
> Then it's probably safer to drop the first hunk - or restore to v1
> 
> https://lore.kernel.org/linux-can/fdab0848a377969142f5ff9aea79c4e357a72474.1755276597.git.dcaratti@redhat.com/

And I see that the build [1] is doing:

  CLEAN   scripts
  CLEAN   include/config include/generated arch/x86/include/generated .config .config.old .version Module.symvers
> TREE CMD: vng -v -b -f tools/testing/selftests/net/config -f tools/testing/selftests/net/af_unix/config
  HOSTCC  scripts/basic/fixdep
  HOSTCC  scripts/kconfig/conf.o

[1] https://netdev-3.bots.linux.dev/vmksft-net/results/291401/build/stdout 

while the enablement of CONFIG_CAN_VCAN is still necessary, the contents of selftests/net/config need to be preserved.
@Jakub,  @Marc, we can drop this patch from the series and I will respin to linux-can ? or you can adjust things in other ways?
-- 
davide