netdev - Re: [PATCH net-next 0/8] tools: ynl: fix errors reported by Ruff

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <m2wm66y9hk.fsf@gmail.com>
Date: Wed, 10 Sep 2025 09:53:11 +0100
From: Donald Hunter <donald.hunter@...il.com>
To: "Matthieu Baerts (NGI0)" <matttbe@...nel.org>
Cc: Jakub Kicinski <kuba@...nel.org>,  "David S. Miller"
 <davem@...emloft.net>,  Eric Dumazet <edumazet@...gle.com>,  Paolo Abeni
 <pabeni@...hat.com>,  Simon Horman <horms@...nel.org>,
  netdev@...r.kernel.org,  linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 0/8] tools: ynl: fix errors reported by Ruff

"Matthieu Baerts (NGI0)" <matttbe@...nel.org> writes:

> When looking at the YNL code to add a new feature, my text editor
> automatically executed 'ruff check', and found out at least one
> interesting error: one variable was used while not being defined.
>
> I then decided to fix this error, and all the other ones reported by
> Ruff. After this series, 'ruff check' reports no more errors with
> version 0.12.12.
>
> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@...nel.org>
> ---
> Matthieu Baerts (NGI0) (8):
>       tools: ynl: fix undefined variable name
>       tools: ynl: avoid bare except
>       tools: ynl: remove assigned but never used variable
>       tools: ynl: remove f-string without any placeholders
>       tools: ynl: remove unused imports
>       tools: ynl: remove unnecessary semicolons
>       tools: ynl: use 'cond is None'
>       tools: ynl: check for membership with 'not in'

The series looks good to me, thanks for the fixes.

Reviewed-by: Donald Hunter <donald.hunter@...il.com>