netdev - Re: [PATCH] net/smc: replace strncpy with strscpy for ib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250910100100.GM341237@unreal>
Date: Wed, 10 Sep 2025 13:01:00 +0300
From: Leon Romanovsky <leon@...nel.org>
To: Kriish Sharma <kriish.sharma2006@...il.com>
Cc: alibuda@...ux.alibaba.com, dust.li@...ux.alibaba.com,
	sidraya@...ux.ibm.com, wenjia@...ux.ibm.com, mjambigi@...ux.ibm.com,
	tonylu@...ux.alibaba.com, guwen@...ux.alibaba.com,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, horms@...nel.org, linux-rdma@...r.kernel.org,
	linux-s390@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, skhan@...uxfoundation.org,
	linux-kernel-mentees@...ts.linuxfoundation.org
Subject: Re: [PATCH] net/smc: replace strncpy with strscpy for ib_name

On Mon, Sep 08, 2025 at 06:09:13PM +0000, Kriish Sharma wrote:
> Replace the deprecated strncpy() with strscpy() for ib_name in
> smc_pnet_add_ib(). The destination buffer should be NUL-terminated and
> does not require any trailing NUL-padding. Since ib_name is a fixed-size
> array, the two-argument form of strscpy() is sufficient and preferred.
> 
> Signed-off-by: Kriish Sharma <kriish.sharma2006@...il.com>
> ---
>  net/smc/smc_pnet.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/smc/smc_pnet.c b/net/smc/smc_pnet.c
> index 76ad29e31d60..b90337f86e83 100644
> --- a/net/smc/smc_pnet.c
> +++ b/net/smc/smc_pnet.c
> @@ -450,7 +450,7 @@ static int smc_pnet_add_ib(struct smc_pnettable *pnettable, char *ib_name,
>  		return -ENOMEM;
>  	new_pe->type = SMC_PNET_IB;
>  	memcpy(new_pe->pnet_name, pnet_name, SMC_MAX_PNETID_LEN);
> -	strncpy(new_pe->ib_name, ib_name, IB_DEVICE_NAME_MAX);
> +	strscpy(new_pe->ib_name, ib_name);

It is worth to mention that caching ib_name is wrong as IB/core provides
IB device rename functionality.

Thanks

>  	new_pe->ib_port = ib_port;
>  
>  	new_ibdev = true;
> -- 
> 2.34.1
> 
>