netdev - RE: [PATCH net-next v5 2/7] bonding: Adding extra_len field to struct bond_opt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <MW3PR15MB39134B21681849AFF5F1431AFA0EA@MW3PR15MB3913.namprd15.prod.outlook.com>
Date: Wed, 10 Sep 2025 16:23:00 +0000
From: David Wilder <wilder@...ibm.com>
To: Paolo Abeni <pabeni@...hat.com>,
        "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>
CC: "jv@...sburgh.net" <jv@...sburgh.net>,
        "pradeeps@...ux.vnet.ibm.com"
	<pradeeps@...ux.vnet.ibm.com>,
        Pradeep Satyanarayana <pradeep@...ibm.com>,
        "i.maximets@....org" <i.maximets@....org>,
        Adrian Moreno Zapata
	<amorenoz@...hat.com>,
        Hangbin Liu <haliu@...hat.com>
Subject: RE: [PATCH net-next v5 2/7] bonding: Adding extra_len field to struct
 bond_opt_value.

________________________________________
From: Paolo Abeni 
Sent: Tuesday, September 9, 2025 6:23 AM
To: David Wilder; netdev@...r.kernel.org
Cc: jv@...sburgh.net; pradeeps@...ux.vnet.ibm.com; Pradeep Satyanarayana; i.maximets@....org; Adrian Moreno Zapata; Hangbin Liu
Subject: [EXTERNAL] Re: [PATCH net-next v5 2/7] bonding: Adding extra_len field to struct bond_opt_value.

 On 7/15/25 12:54 AM, David Wilder wrote:
> > Used to record the size of the extra array.
> >
> > __bond_opt_init() is updated to set extra_len.
> > BOND_OPT_EXTRA_MAXLEN is increased from 16 to 64.
>
> Why 64? AFAICS it will still not allow fitting BOND_MAX_ARP_TARGETS in a
> single buffer, and later code will try to do that.
>
> /P

No need to fit an entire BOND_MAX_ARP_TARGETS entries here.
IFLA_BOND_ARP_IP_TARGET is a nested attribute, only a single entry
at a time in this buffer. One ipv4 address + 5 struct bond_vlan_tag.
32 bytes would be enough but I am planning for ns_ip6_target changes.
and I am paranoid :)

David Wilder