netdev - RE: [PATCH net-next v5 1/7] bonding: Adding struct bond_arp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <MW3PR15MB3913542894107D1ADCFAF8EEFA0EA@MW3PR15MB3913.namprd15.prod.outlook.com>
Date: Wed, 10 Sep 2025 16:30:06 +0000
From: David Wilder <wilder@...ibm.com>
To: Paolo Abeni <pabeni@...hat.com>,
        "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>
CC: "jv@...sburgh.net" <jv@...sburgh.net>,
        "pradeeps@...ux.vnet.ibm.com"
	<pradeeps@...ux.vnet.ibm.com>,
        Pradeep Satyanarayana <pradeep@...ibm.com>,
        "i.maximets@....org" <i.maximets@....org>,
        Adrian Moreno Zapata
	<amorenoz@...hat.com>,
        Hangbin Liu <haliu@...hat.com>
Subject: RE: [PATCH net-next v5 1/7] bonding: Adding struct bond_arp_target




________________________________________
From: Paolo Abeni <pabeni@...hat.com>
Sent: Tuesday, September 9, 2025 6:21 AM
To: David Wilder; netdev@...r.kernel.org
Cc: jv@...sburgh.net; pradeeps@...ux.vnet.ibm.com; Pradeep Satyanarayana; i.maximets@....org; Adrian Moreno Zapata; Hangbin Liu
Subject: [EXTERNAL] Re: [PATCH net-next v5 1/7] bonding: Adding struct bond_arp_target

> On 7/15/25 12:54 AM, David Wilder wrote:
> > Replacing the definition of bond_params.arp_targets (__be32 arp_targets[])
> > with:
> >
> > struct bond_arp_target {
> >       __be32                  target_ip;
> >       struct bond_vlan_tag    *tags;
> >       u32                     flags;
> > };
>
> The above struct is going to be allocated on the stack and has 2 holes 4
> bytes each.
>
> If you change the layout as follow:
>
> struct bond_arp_target {
>         __be32                  target_ip;
>         u32                     flags;
>         struct bond_vlan_tag    *tags;
> };

> the struct size will be 8 bytes less.
>
> /P

Cool. Thank you for the suggestion Paolo.
I will make the change.