netdev - Re: [PATCH net-next 2/2] net: phylink: warn if deprecated array-style fixed-link binding is used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bb41943c-991a-46bc-a0de-e2f3f1295dc4@gmail.com>
Date: Thu, 11 Sep 2025 18:28:03 +0200
From: Heiner Kallweit <hkallweit1@...il.com>
To: Krzysztof Kozlowski <krzk@...nel.org>,
 Russell King - ARM Linux <linux@...linux.org.uk>,
 Andrew Lunn <andrew@...n.ch>, Andrew Lunn <andrew+netdev@...n.ch>,
 Paolo Abeni <pabeni@...hat.com>, Jakub Kicinski <kuba@...nel.org>,
 Eric Dumazet <edumazet@...gle.com>, David Miller <davem@...emloft.net>
Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 2/2] net: phylink: warn if deprecated array-style
 fixed-link binding is used

On 9/11/2025 8:34 AM, Krzysztof Kozlowski wrote:
> On 09/09/2025 21:16, Heiner Kallweit wrote:
>> The array-style fixed-link binding has been marked deprecated for more
>> than 10 yrs, but still there's a number of users. Print a warning when
>> usage of the deprecated binding is detected.
>>
>> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
>> ---
>>  drivers/net/phy/phylink.c | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
>> index c7f867b36..d3cb52717 100644
>> --- a/drivers/net/phy/phylink.c
>> +++ b/drivers/net/phy/phylink.c
>> @@ -700,6 +700,9 @@ static int phylink_parse_fixedlink(struct phylink *pl,
>>  			return -EINVAL;
>>  		}
>>  
>> +		phylink_warn(pl, "%s uses deprecated array-style fixed-link binding!",
>> +			     fwnode_get_name(fwnode));
> Similar comment as for patch #1 - this seems to be going to printk, so
> use proper % format for fwnodes (I think there is as well such).
> 
At least here no format for fwnodes is mentioned.
https://www.kernel.org/doc/Documentation/printk-formats.txt

> Best regards,
> Krzysztof