netdev - Re: [PATCH net] ionic: use int type for err in ionic_get_module_eeprom_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5c7de370-1fe1-4fbb-9e93-9b20fb3763e5@onemain.com>
Date: Wed, 10 Sep 2025 23:19:14 -0700
From: Shannon Nelson <sln@...main.com>
To: Alok Tiwari <alok.a.tiwari@...cle.com>, shannon.nelson@....com,
 brett.creeley@....com, andrew+netdev@...n.ch, davem@...emloft.net,
 edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, horms@...nel.org,
 netdev@...r.kernel.org
Subject: Re: [PATCH net] ionic: use int type for err in
 ionic_get_module_eeprom_by_page

On 9/10/25 9:23 PM, Alok Tiwari wrote:
> The variable 'err' is declared as u32, but it is used to store
> negative error codes such as -EINVAL.
>
> Changing the type of 'err' to int ensures proper representation of
> negative error codes and aligns with standard kernel error handling
> conventions.
>
> Fixes: c51ab838f532 ("ionic: extend the QSFP module sprom for more pages")
> Signed-off-by: Alok Tiwari <alok.a.tiwari@...cle.com>
> ---
>   drivers/net/ethernet/pensando/ionic/ionic_ethtool.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c b/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c
> index 92f30ff2d631..c3f9835446e2 100644
> --- a/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c
> +++ b/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c
> @@ -978,7 +978,7 @@ static int ionic_get_module_eeprom_by_page(struct net_device *netdev,
>   {
>   	struct ionic_lif *lif = netdev_priv(netdev);
>   	struct ionic_dev *idev = &lif->ionic->idev;
> -	u32 err = -EINVAL;
> +	int err = -EINVAL;

Yikes, how'd we manage that?
Thanks for catching it.

Reviewed-by: Shannon Nelson <sln@...main.com>

>   	u8 *src;
>   
>   	if (!page_data->length)