netdev - Re: [PATCH iproute2-next] tc/police: Allow 64 bit burst size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+NMeC--TzdxWC=3mXT3+NJE_gSQ3D1htFGMo2HHZVC7pcxkYA@mail.gmail.com>
Date: Fri, 12 Sep 2025 12:48:10 -0300
From: Victor Nogueira <victor@...atatu.com>
To: Jamal Hadi Salim <jhs@...atatu.com>
Cc: Jay Vosburgh <jay.vosburgh@...onical.com>, David Ahern <dsahern@...il.com>, 
	netdev@...r.kernel.org, Stephen Hemminger <stephen@...workplumber.org>
Subject: Re: [PATCH iproute2-next] tc/police: Allow 64 bit burst size

On Fri, Sep 12, 2025 at 11:31 AM Jamal Hadi Salim <jhs@...atatu.com> wrote:
>
> On Fri, Sep 12, 2025 at 12:19 AM Jay Vosburgh
> <jay.vosburgh@...onical.com> wrote:
> >
> > > [...]
> > >You say the change looks fine but at least one test fails meaning
> > >changes are requested?
> >
> >         Yes, I ran the tests and saw one failure, in the following:
> >
> >         "cmdUnderTest": "$TC actions add action police pkts_rate 1000 pkts_burst
> >  200 index 1",
> >         "expExitCode": "0",
> >         "verifyCmd": "$TC actions ls action police",
> >         "matchPattern": "action order [0-9]*:  police 0x1 rate 0bit burst 0b mtu 4096Mb pkts_rate 1000 pkts_burst 200",
> >
> >         Which is trying to match a returned mtu value of "4096Mb" but
> > the new code prints "4Gb"; should be straightforward to change the test
> > to accept either returned value.
> > [...]
> >
>
> For backward compat we need to support both. IOW, if someone was using
> an older tc then a new kernel should work fine and not fail because of
> different output expected. @Victor Nogueira wanna take a crack at
> fixing the test? Then when the iproute side is merged as is - both
> should work.

Yes, I just sent a patch making the test work with both Mb and Gb [1].

[1] https://lore.kernel.org/netdev/20250912154616.67489-1-victor@mojatatu.com/

cheers,
Victor