[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAM0EoMmA1j=q0XtNB_Xax2eVuyAKtnrkkZuXAm3O34asqGNk0g@mail.gmail.com>
Date: Mon, 15 Sep 2025 03:51:36 -0400
From: Jamal Hadi Salim <jhs@...atatu.com>
To: David Ahern <dsahern@...il.com>
Cc: Jay Vosburgh <jay.vosburgh@...onical.com>, netdev@...r.kernel.org,
Stephen Hemminger <stephen@...workplumber.org>
Subject: Re: [PATCH iproute2-next] tc/police: Allow 64 bit burst size
On Thu, Sep 11, 2025 at 4:50 PM David Ahern <dsahern@...il.com> wrote:
>
> On 9/9/25 9:32 PM, Jamal Hadi Salim wrote:
> >
> > Please run tdc tests. David/Stephen - can we please make this a
> > requirement for iproute2 tc related changes?
>
> I will try to remember to run tdc tests for tc patches. Without an
> automated setup, there will be misses over time.
>
> >
> > Jay, your patches fail at least one test because you changed the unit outputs.
> > Either we fix the tdc test or you make your changes backward compatible.
> > In the future also cc kernel tc maintainers (I only saw this because
> > someone pointed it to me).
> > Overall the changes look fine.
>
> Sent a patch to add a tc entry to iproute2 maintainers file.
>
> You say the change looks fine but at least one test fails meaning
> changes are requested?
Pending the kernel patch being applied...
Acked-by: Jamal Hadi Salim
cheers,
jamal
Powered by blists - more mailing lists