netdev - Re: [PATCH v2 net] net: ena: fix duplicate Autoneg setting in get_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <96f1e320-a777-4828-a681-80f81f9a44de@lunn.ch>
Date: Fri, 12 Sep 2025 22:43:02 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Alok Tiwari <alok.a.tiwari@...cle.com>
Cc: shayagr@...zon.com, akiyano@...zon.com, saeedb@...zon.com,
	darinzon@...zon.com, andrew+netdev@...n.ch, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	horms@...nel.org, netdev@...r.kernel.org
Subject: Re: [PATCH v2 net] net: ena: fix duplicate Autoneg setting in
 get_link_ksettings

On Fri, Sep 12, 2025 at 01:21:59PM -0700, Alok Tiwari wrote:
> The ENA ethtool implementation is setting Autoneg twice in the
> 'supported' bitfield, leaving 'advertising' unset.
> 
> ENA devices always support Autoneg, so 'supported' should always have
> the bit set unconditionally. 'advertising' should only be set when
> ENA_ADMIN_GET_FEATURE_LINK_DESC_AUTONEG_MASK is present, since that
> reflects runtime enablement.
> 
> Fix by unconditionally setting Autoneg in 'supported' and moving the
> conditional flag check to 'advertising'
> 
> Fixes: 1738cd3ed342 ("net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)")
> Signed-off-by: Alok Tiwari <alok.a.tiwari@...cle.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew