netdev - Re: [PATCH v2 net] net: ena: fix duplicate Autoneg setting in get_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <B0D2CFDF-B86E-4C27-9ADE-8A9295C60656@amazon.com>
Date: Mon, 15 Sep 2025 17:33:46 +0000
From: "Belgazal, Netanel" <netanel@...zon.com>
To: Andrew Lunn <andrew@...n.ch>, Alok Tiwari <alok.a.tiwari@...cle.com>
CC: "Allen, Neil" <shayagr@...zon.com>, "Kiyanovski, Arthur"
	<akiyano@...zon.com>, "Bshara, Saeed" <saeedb@...zon.com>, "Arinzon, David"
	<darinzon@...zon.com>, "andrew+netdev@...n.ch" <andrew+netdev@...n.ch>,
	"davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>, "horms@...nel.org"
	<horms@...nel.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH v2 net] net: ena: fix duplicate Autoneg setting in
 get_link_ksettings

Thanks for highlighting the issue and sharing the patch. The feature was added a long time ago with the thought of potential support of ENA link auto negotiation, but the ENA device doesn't report or allow users to configure link auto negotiation.
I believe the best approach is to remove the entire auto negotiation section from the ethtool callbbacks.

On 9/12/25, 1:43 PM, "Andrew Lunn" <andrew@...n.ch <mailto:andrew@...n.ch>> wrote:


On Fri, Sep 12, 2025 at 01:21:59PM -0700, Alok Tiwari wrote:
> The ENA ethtool implementation is setting Autoneg twice in the
> 'supported' bitfield, leaving 'advertising' unset.
> 
> ENA devices always support Autoneg, so 'supported' should always have
> the bit set unconditionally. 'advertising' should only be set when
> ENA_ADMIN_GET_FEATURE_LINK_DESC_AUTONEG_MASK is present, since that
> reflects runtime enablement.
> 
> Fix by unconditionally setting Autoneg in 'supported' and moving the
> conditional flag check to 'advertising'
> 
> Fixes: 1738cd3ed342 ("net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)")
> Signed-off-by: Alok Tiwari <alok.a.tiwari@...cle.com <mailto:alok.a.tiwari@...cle.com>>


Reviewed-by: Andrew Lunn <andrew@...n.ch <mailto:andrew@...n.ch>>


Andrew