netdev - Re: [PATCH] doc/netlink: Fix typos in operation attributes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250915182636.7284c0ad@kernel.org>
Date: Mon, 15 Sep 2025 18:26:36 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: "Remy D. Farley" <one-d-wide@...tonmail.com>
Cc: Donald Hunter <donald.hunter@...il.com>, netdev@...r.kernel.org,
 fw@...len.de
Subject: Re: [PATCH] doc/netlink: Fix typos in operation attributes

On Sat, 13 Sep 2025 14:05:28 +0000 Remy D. Farley wrote:
> I'm trying to generate Rust bindings for netlink using the yaml spec.
> 
> It looks like there's a typo in conntrack spec: attribute set conntrack-attrs
> defines attributes "counters-{orig,reply}" (plural), while get operation
> references "counter-{orig,reply}" (singular). The latter should be fixed, as it
> denotes multiple counters (packet and byte). The corresonding C define is
> CTA_COUNTERS_ORIG.
> 
> Also, dump request references "nfgen-family" attribute, which neither exists in
> conntrack-attrs attrset nor ctattr_type enum. There's member of nfgenmsg struct
> with the same name, which is where family value is actually taken from.
> 
> > static int ctnetlink_dump_exp_ct(struct net *net, struct sock *ctnl,
> >                struct sk_buff *skb,
> >                const struct nlmsghdr *nlh,
> >                const struct nlattr * const cda[],
> >                struct netlink_ext_ack *extack)
> > {
> >   int err;
> >   struct nfgenmsg *nfmsg = nlmsg_data(nlh);
> >   u_int8_t u3 = nfmsg->nfgen_family;  
>                          ^^^^^^^^^^^^

cc: fw@...len.de
Fixes: 23fc9311a526 ("netlink: specs: add conntrack dump and stats dump support")
Reviewed-by: Jakub Kicinski <kuba@...nel.org>

>  Documentation/netlink/specs/conntrack.yaml | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/netlink/specs/conntrack.yaml b/Documentation/netlink/specs/conntrack.yaml
> index c6832633a..591e22a2e 100644
> --- a/Documentation/netlink/specs/conntrack.yaml
> +++ b/Documentation/netlink/specs/conntrack.yaml
> @@ -575,8 +575,8 @@ operations:
>              - nat-dst
>              - timeout
>              - mark
> -            - counter-orig
> -            - counter-reply
> +            - counters-orig
> +            - counters-reply
>              - use
>              - id
>              - nat-dst
> @@ -591,7 +591,6 @@ operations:
>          request:
>            value: 0x101
>            attributes:
> -            - nfgen-family
>              - mark
>              - filter
>              - status
> @@ -608,8 +607,8 @@ operations:
>              - nat-dst
>              - timeout
>              - mark
> -            - counter-orig
> -            - counter-reply
> +            - counters-orig
> +            - counters-reply
>              - use
>              - id
>              - nat-dst