netdev - Re: [PATCH net-next 2/7] net: sfp: pre-parse the module support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aMnZ40TN68WhWcMb@shell.armlinux.org.uk>
Date: Tue, 16 Sep 2025 22:42:59 +0100
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: Andrew Lunn <andrew@...n.ch>
Cc: Heiner Kallweit <hkallweit1@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, linux-arm-msm@...r.kernel.org,
	Marek Beh__n <kabel@...nel.org>, netdev@...r.kernel.org,
	Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net-next 2/7] net: sfp: pre-parse the module support

On Mon, Sep 15, 2025 at 05:12:19PM +0200, Andrew Lunn wrote:
> > +static void sfp_module_may_have_phy(struct sfp_bus *bus,
> > +				    const struct sfp_eeprom_id *id)
> > +{
> 
> _may_have_phy() sounds like a question, and you would expect a return
> value as the answer. But that is not what this does.
> 
> Maybe sfp_module_set_may_have_phy()? 

I'll stick a parse_ in there rather than set_ so it matches all the
others which are parsing the SFP ID to obtain something.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!