netdev - Re: [PATCH 2/8] RDMA/bng_re: Add Auxiliary interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMet4B5jDjzbi15f7jNvs31hGgX-pidtC_uvd7+dMjgay4=Law@mail.gmail.com>
Date: Wed, 17 Sep 2025 14:47:38 +0530
From: Siva Reddy Kallam <siva.kallam@...adcom.com>
To: Simon Horman <horms@...nel.org>
Cc: leonro@...dia.com, jgg@...dia.com, linux-rdma@...r.kernel.org, 
	netdev@...r.kernel.org, vikas.gupta@...adcom.com, selvin.xavier@...adcom.com, 
	anand.subramanian@...adcom.com, Usman Ansari <usman.ansari@...adcom.com>
Subject: Re: [PATCH 2/8] RDMA/bng_re: Add Auxiliary interface

On Tue, Sep 16, 2025 at 6:04 PM Simon Horman <horms@...nel.org> wrote:
>
> On Fri, Aug 29, 2025 at 12:30:36PM +0000, Siva Reddy Kallam wrote:
> > Add basic Auxiliary interface to the driver which supports
> > the BCM5770X NIC family.
> >
> > Signed-off-by: Siva Reddy Kallam <siva.kallam@...adcom.com>
> > Reviewed-by: Usman Ansari <usman.ansari@...adcom.com>
>
> ...
>
> > diff --git a/drivers/infiniband/hw/bng_re/bng_dev.c b/drivers/infiniband/hw/bng_re/bng_dev.c
>
> ...
>
> > +static int bng_re_add_device(struct auxiliary_device *adev)
> > +{
> > +     struct bnge_auxr_priv *auxr_priv =
> > +             container_of(adev, struct bnge_auxr_priv, aux_dev);
> > +     struct bng_re_en_dev_info *dev_info;
> > +     struct bng_re_dev *rdev;
> > +     int rc;
> > +
> > +     dev_info = auxiliary_get_drvdata(adev);
> > +
> > +     rdev = bng_re_dev_add(adev, auxr_priv->auxr_dev);
> > +     if (!rdev || !rdev_to_dev(rdev)) {
>
> Hi Siva,
>
> Sorry if somehow this is a duplicate, it got stuck in my outbox somehow.
>
> GCC 15.1.0 says:
>
>   .../bng_dev.c: In function 'bng_re_add_device':
>   .../bng_dev.c:54:22: warning: the comparison will always evaluate as 'true' for the address of 'dev' will never be NULL [-Waddress]
>      54 |         if (!rdev || !rdev_to_dev(rdev)) {
>         |                      ^
>   In file included from drivers/infiniband/hw/bng_re/bng_dev.c:8:
>   ./include/rdma/ib_verbs.h:2812:41: note: 'dev' declared here
>    2812 |                 struct device           dev;
>         |
>
> > +             rc = -ENOMEM;
> > +             goto exit;
> > +     }
> > +
> > +     dev_info->rdev = rdev;
> > +
> > +     return 0;
> > +exit:
> > +     return rc;
> > +}
Hi Simon,
No problem. rdev_to_dev check is not needed. We will fix it in the
next version of the patchset.
Thanks
>
> ...