netdev - Re: [PATCH v2 net-next 6/7] mptcp: Call dst_release() in mptcp_active

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <35a48361-c69f-4cf9-aec9-db1ac0597f96@kernel.org>
Date: Wed, 17 Sep 2025 12:17:09 +0200
From: Matthieu Baerts <matttbe@...nel.org>
To: Kuniyuki Iwashima <kuniyu@...gle.com>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Cc: Simon Horman <horms@...nel.org>, Kuniyuki Iwashima <kuni1840@...il.com>,
 netdev@...r.kernel.org, Mat Martineau <martineau@...nel.org>,
 Geliang Tang <geliang@...nel.org>
Subject: Re: [PATCH v2 net-next 6/7] mptcp: Call dst_release() in
 mptcp_active_enable().

Hi Kuniyuki,

On 16/09/2025 23:47, Kuniyuki Iwashima wrote:
> mptcp_active_enable() calls sk_dst_get(), which returns dst with its
> refcount bumped, but forgot dst_release().
> 
> Let's add missing dst_release().
> 
> Fixes: 27069e7cb3d1 ("mptcp: disable active MPTCP in case of blackhole")
> Signed-off-by: Kuniyuki Iwashima <kuniyu@...gle.com>
> ---
> v2: split from the next patch as dst_dev_rcu() patch hasn't been
>     backported to 6.12+, where the cited commit exists.

Thank you for the v2 and for the split!

Reviewed-by: Matthieu Baerts (NGI0) <matttbe@...nel.org>

Ideally, it would be great to if the 'Cc: stable' tag can be added when
applying the patch, so I would be notified in case of issues with the
backport of this patch.

Cc: stable@...r.kernel.org

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.