Message-Id: <175812100719.2051822.15573385822403919775.robh@kernel.org>
Date: Wed, 17 Sep 2025 10:00:43 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Wasim Nazir <wasim.nazir@....qualcomm.com>
Cc: Viken Dadhaniya <viken.dadhaniya@....qualcomm.com>, 
 Monish Chunara <quic_mchunara@...cinc.com>, 
 Krzysztof Kozlowski <krzk+dt@...nel.org>, linux-arm-msm@...r.kernel.org, 
 Konrad Dybcio <konradybcio@...nel.org>, kernel@....qualcomm.com, 
 Conor Dooley <conor+dt@...nel.org>, 
 Richard Cochran <richardcochran@...il.com>, linux-i2c@...r.kernel.org, 
 Konrad Dybcio <konrad.dybcio@....qualcomm.com>, 
 Nirmesh Kumar Singh <quic_nkumarsi@...cinc.com>, 
 Sushrut Shree Trivedi <quic_sushruts@...cinc.com>, 
 Mohd Ayaan Anwar <quic_mohdayaa@...cinc.com>, netdev@...r.kernel.org, 
 Ulf Hansson <ulf.hansson@...aro.org>, linux-kernel@...r.kernel.org, 
 devicetree@...r.kernel.org, Bjorn Andersson <andersson@...nel.org>, 
 Bartosz Golaszewski <bartosz.golaszewski@...aro.org>, 
 Krishna Kurapati <krishna.kurapati@....qualcomm.com>, 
 Vikash Garodia <vikash.garodia@....qualcomm.com>, 
 Bartosz Golaszewski <brgl@...ev.pl>, linux-mmc@...r.kernel.org, 
 Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
Subject: Re: [PATCH v6 00/10] arm64: dts: qcom: lemans-evk: Extend board
 support for additional peripherals


On Tue, 16 Sep 2025 20:29:22 +0530, Wasim Nazir wrote:
> This series extend support for additional peripherals on the Qualcomm
> Lemans EVK board to enhance overall hardware functionality.
> 
> It includes:
>   - New peripherals like:
>     - I2C based devices like GPIO I/O expander and EEPROM.
>     - GPI (Generic Peripheral Interface) DMA controllers and QUPv3 controllers
>       for peripheral communication.
>     - PCIe HW with required regulators and PHYs.
>     - Remoteproc subsystems for supported DSPs.
>     - Iris video codec.
>     - First USB controller in device mode.
>     - SD card support on SDHC v5.
>     - Qca8081 2.5G Ethernet PHY.
> 
> Dependency:
>   - The ethernet PHY QCA8081 depends on CONFIG_QCA808X_PHY, without
>     which ethernet will not work.
> 
> ---
> Changes in v6:
> - Update commit message of patch 02/10 (v5) to reflect QUP interfaces and
>   its ports - Dmitry.
> - Link to v5: https://lore.kernel.org/r/20250916-lemans-evk-bu-v5-0-53d7d206669d@oss.qualcomm.com
> 
> Changes in v5:
> - Dropping these changes from the series, as they are already part of
>   linux-next:
>   - Audio change [1]
>   - MMC dt-bindings change 01/14 (v4)
>   - EEPROM dt-bindings change 05/14 (v4)
> - Change bias to 'pull-up' for PCIe 'perst-pins' - Konrad.
> - Link to v4: [2]
> 
> [1] https://lore.kernel.org/linux-arm-msm/20250822131902.1848802-1-mohammad.rafi.shaik@oss.qualcomm.com/
> [2] https://lore.kernel.org/r/20250908-lemans-evk-bu-v4-0-5c319c696a7d@oss.qualcomm.com
> 
> Changes in v4:
> - Move 'bus-width' property of SDHC to Board DT and also keep the width
>   to 4 bits - Dmitry/Konrad.
> - Update commit text of eeprom bindings to describe the reason for the
>   change 05/14 (v3) - Dmitry.
> - Bring all tags from v3.
> - Link to v3: https://lore.kernel.org/r/20250904-lemans-evk-bu-v3-0-8bbaac1f25e8@oss.qualcomm.com
> 
> Changes in v3:
> - Re-order QUP patch 05/13 (v2) to not break i2c node enablement in patch
>   03/13 (v2) - Dmitry.
> - Update commit text for QUP patch to highlight which all clients each
>   QUP is accessing.
> - Add dedicated compatible for Giantec EEPROM, because usage of generic
>   compatible "atmel,24c256" alone is not advised.
> - Update commit text for EEPROM patch 04/13 (v2) to emphasize on EEPROM
>   enablement - Konrad.
> - Put 'reg' property after 'compatible' in Expander - Konrad.
> - Put 'pinctrl-names' after 'pinctrl-n' in PCIe - Konrad.
> - SDHC:
>     - Update interconnect nodes with ICC_TAG macro - Konrad.
>     - Put new lines for each entry in interrupt-names, clock-names,
>       interconnect-names - Konrad.
>     - Put bias properties below drive-strength for consistency in
>       sdc-default-state - Konrad.
>     - Move 'bus-width' property to SOC DT - Konrad.
>     - Move 'no-mmc' and 'no-sdio' properties to board DT - Dmitry/Konrad.
> - Add 'Reviewed-by' tag from Konrad [3] on Audio patch 13/13 (v2),
>   although the commit text is changed now.
> - Link to v2: [4]
> 
> [3] https://lore.kernel.org/linux-arm-msm/b4b6678b-46dd-4f57-9c26-ff0e4108bf79@oss.qualcomm.com/
> [4] https://lore.kernel.org/r/20250903-lemans-evk-bu-v2-0-bfa381bf8ba2@oss.qualcomm.com
> 
> Changes in v2:
> - Split the patch 3/5 in v1 into separate patch per author - Bjorn.
> - Use generic node names for expander - Krzysztof.
> - Change video firmware to 16MB comapatible - Dmitry.
> - SDHC:
>     - Arrange SDHCI-compatible alphanumerically - Dmitry.
>     - Move OPP table and power-domains to lemans.dtsi as these are
>       part of SoC.
>     - Move bus-width to board file - Dmitry.
>     - Change 'states' property to array in vreg_sdc and also re-arrange
>       the other properties.
> - Remove the redundant snps,ps-speed property from the ethernet node as
>   the MAC is actually relying on PCS auto-negotiation to set its speed
>   (via ethqos_configure_sgmii called as part of mac_link_up).
> - Refine commit text for audio patch - Bjorn.
> - Link to v1: https://lore.kernel.org/r/20250826-lemans-evk-bu-v1-0-08016e0d3ce5@oss.qualcomm.com
> 
> ---
> Krishna Kurapati (1):
>       arm64: dts: qcom: lemans-evk: Enable first USB controller in device mode
> 
> Mohd Ayaan Anwar (1):
>       arm64: dts: qcom: lemans-evk: Enable 2.5G Ethernet interface
> 
> Monish Chunara (3):
>       arm64: dts: qcom: lemans: Add SDHC controller and SDC pin configuration
>       arm64: dts: qcom: lemans-evk: Add EEPROM and nvmem layout
>       arm64: dts: qcom: lemans-evk: Enable SDHCI for SD Card
> 
> Nirmesh Kumar Singh (1):
>       arm64: dts: qcom: lemans-evk: Add TCA9534 I/O expander
> 
> Sushrut Shree Trivedi (1):
>       arm64: dts: qcom: lemans-evk: Enable PCIe support
> 
> Vikash Garodia (1):
>       arm64: dts: qcom: lemans-evk: Enable Iris video codec support
> 
> Viken Dadhaniya (1):
>       arm64: dts: qcom: lemans-evk: Enable GPI DMA and QUPv3 controllers
> 
> Wasim Nazir (1):
>       arm64: dts: qcom: lemans-evk: Enable remoteproc subsystems
> 
>  arch/arm64/boot/dts/qcom/lemans-evk.dts | 365 ++++++++++++++++++++++++++++++++
>  arch/arm64/boot/dts/qcom/lemans.dtsi    |  92 ++++++++
>  2 files changed, 457 insertions(+)
> ---
> base-commit: c3067c2c38316c3ef013636c93daa285ee6aaa2e
> change-id: 20250814-lemans-evk-bu-ec015ce4080e
> 
> Best regards,
> --
> Wasim Nazir <wasim.nazir@....qualcomm.com>
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


This patch series was applied (using b4) to base:
 Base: using specified base-commit c3067c2c38316c3ef013636c93daa285ee6aaa2e

If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)

New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/qcom/' for 20250916-lemans-evk-bu-v6-0-62e6a9018df4@....qualcomm.com:

arch/arm64/boot/dts/qcom/sa8775p-ride.dtb: displayport-controller@...4000 (qcom,sa8775p-dp): clocks: [[251, 1], [251, 11], [251, 15], [251, 18], [251, 19]] is too short
	from schema $id: http://devicetree.org/schemas/display/msm/dp-controller.yaml#
arch/arm64/boot/dts/qcom/qcs9100-ride.dtb: displayport-controller@...4000 (qcom,sa8775p-dp): clocks: [[250, 1], [250, 11], [250, 15], [250, 18], [250, 19]] is too short
	from schema $id: http://devicetree.org/schemas/display/msm/dp-controller.yaml#
arch/arm64/boot/dts/qcom/sa8775p-ride.dtb: displayport-controller@...c000 (qcom,sa8775p-dp): clocks: [[251, 1], [251, 28], [251, 32], [251, 35], [251, 36]] is too short
	from schema $id: http://devicetree.org/schemas/display/msm/dp-controller.yaml#
arch/arm64/boot/dts/qcom/qcs9100-ride.dtb: displayport-controller@...c000 (qcom,sa8775p-dp): clocks: [[250, 1], [250, 28], [250, 32], [250, 35], [250, 36]] is too short
	from schema $id: http://devicetree.org/schemas/display/msm/dp-controller.yaml#
arch/arm64/boot/dts/qcom/qcs9100-ride-r3.dtb: displayport-controller@...4000 (qcom,sa8775p-dp): clocks: [[250, 1], [250, 11], [250, 15], [250, 18], [250, 19]] is too short
	from schema $id: http://devicetree.org/schemas/display/msm/dp-controller.yaml#
arch/arm64/boot/dts/qcom/qcs9100-ride-r3.dtb: displayport-controller@...c000 (qcom,sa8775p-dp): clocks: [[250, 1], [250, 28], [250, 32], [250, 35], [250, 36]] is too short
	from schema $id: http://devicetree.org/schemas/display/msm/dp-controller.yaml#
arch/arm64/boot/dts/qcom/sa8775p-ride-r3.dtb: displayport-controller@...4000 (qcom,sa8775p-dp): clocks: [[251, 1], [251, 11], [251, 15], [251, 18], [251, 19]] is too short
	from schema $id: http://devicetree.org/schemas/display/msm/dp-controller.yaml#
arch/arm64/boot/dts/qcom/lemans-evk.dtb: displayport-controller@...4000 (qcom,sa8775p-dp): clocks: [[236, 1], [236, 11], [236, 15], [236, 18], [236, 19]] is too short
	from schema $id: http://devicetree.org/schemas/display/msm/dp-controller.yaml#
arch/arm64/boot/dts/qcom/sa8775p-ride-r3.dtb: displayport-controller@...c000 (qcom,sa8775p-dp): clocks: [[251, 1], [251, 28], [251, 32], [251, 35], [251, 36]] is too short
	from schema $id: http://devicetree.org/schemas/display/msm/dp-controller.yaml#
arch/arm64/boot/dts/qcom/lemans-evk.dtb: displayport-controller@...c000 (qcom,sa8775p-dp): clocks: [[236, 1], [236, 28], [236, 32], [236, 35], [236, 36]] is too short
	from schema $id: http://devicetree.org/schemas/display/msm/dp-controller.yaml#
arch/arm64/boot/dts/qcom/lemans-evk.dtb: ethernet@...40000 (qcom,sa8775p-ethqos): Unevaluated properties are not allowed ('interconnect-names', 'interconnects' were unexpected)
	from schema $id: http://devicetree.org/schemas/net/qcom,ethqos.yaml#

Powered by blists - more mailing lists