netdev - Re: [PATCH net-next v4 1/2] net: libwx: support multiple RSS for every pool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250917141313.43b71217@kernel.org>
Date: Wed, 17 Sep 2025 14:13:13 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Jiawen Wu <jiawenwu@...stnetic.com>
Cc: <netdev@...r.kernel.org>, "'Andrew Lunn'" <andrew+netdev@...n.ch>,
 "'David S. Miller'" <davem@...emloft.net>, "'Eric Dumazet'"
 <edumazet@...gle.com>, "'Paolo Abeni'" <pabeni@...hat.com>, "'Simon
 Horman'" <horms@...nel.org>, "'Alexander Lobakin'"
 <aleksander.lobakin@...el.com>, "'Mengyuan Lou'"
 <mengyuanlou@...-swift.com>
Subject: Re: [PATCH net-next v4 1/2] net: libwx: support multiple RSS for
 every pool

On Wed, 17 Sep 2025 15:38:45 +0800 Jiawen Wu wrote:
> > > Deleting VFs will reset these configurations.  
> > 
> > You shouldn't reset user-set configuration of the PF when SR-IOV
> > is disabled.  
> 
> But the maximum queue number of PF is different when SRIOV is
> enabled or disabled?
> 
> And for the global RSS table (non SR-IOV mode) or multiple RSS table
> (SR-IOV mode), the table size is different on hardware design.
> 
> How could I keep the RSS redirection table during the mode switching?

Only if the user requested a particular config.

If netif_is_rxfh_configured() returns true and the RSS table contains
the ring you're trying to disable you should reject the attempt to
enable SRIOV.

For the change in table size you can just reject if
netif_is_rxfh_configured() for simplicity (user can reset the table using 
ethtool -X $ifc default
You could support "shrinking" the table if both sub-tables are
identical. But IDK if its worth the effort. Setting custom indir tables
is fairly rare.