netdev - RE: [PATCH net-next v4 1/2] net: libwx: support multiple RSS for every pool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <039301dc27a6$194e79a0$4beb6ce0$@trustnetic.com>
Date: Wed, 17 Sep 2025 15:38:45 +0800
From: Jiawen Wu <jiawenwu@...stnetic.com>
To: "'Jakub Kicinski'" <kuba@...nel.org>
Cc: <netdev@...r.kernel.org>,
	"'Andrew Lunn'" <andrew+netdev@...n.ch>,
	"'David S. Miller'" <davem@...emloft.net>,
	"'Eric Dumazet'" <edumazet@...gle.com>,
	"'Paolo Abeni'" <pabeni@...hat.com>,
	"'Simon Horman'" <horms@...nel.org>,
	"'Alexander Lobakin'" <aleksander.lobakin@...el.com>,
	"'Mengyuan Lou'" <mengyuanlou@...-swift.com>
Subject: RE: [PATCH net-next v4 1/2] net: libwx: support multiple RSS for every pool

On Wed, Sep 17, 2025 10:26 AM, Jakub Kicinski wrote:
> On Wed, 17 Sep 2025 09:51:44 +0800 Jiawen Wu wrote:
> > On Tue, Sep 16, 2025 9:02 AM, Jakub Kicinski wrote:
> > > On Fri, 12 Sep 2025 14:23:56 +0800 Jiawen Wu wrote:
> > > > Subject: [PATCH net-next v4 1/2] net: libwx: support multiple RSS for every pool
> > >
> > > "support multiple RSS" needs an object. Multiple RSS keys? Multiple
> > > contexts? Multiple tables?
> >
> > All of these are multiple. Each pool has a different RSS scheme.
> 
> Then configuration?
> As in "support separate RSS configuration for every pool" ?
> 
> > > > -static void wx_store_reta(struct wx *wx)
> > > > +u32 wx_rss_indir_tbl_entries(struct wx *wx)
> > > >  {
> > > > +	if (test_bit(WX_FLAG_SRIOV_ENABLED, wx->flags))
> > > > +		return 64;
> > > > +	else
> > > > +		return 128;
> > > > +}
> > >
> > > Is WX_FLAG_SRIOV_ENABLED set only when VFs are created?
> >
> > Yes.
> >
> > > What if the user set a table with 128 entries?
> > > The RSS table can't shrink once intentionally set to a specific size.
> >
> > Deleting VFs will reset these configurations.
> 
> You shouldn't reset user-set configuration of the PF when SR-IOV
> is disabled.

But the maximum queue number of PF is different when SRIOV is
enabled or disabled?

And for the global RSS table (non SR-IOV mode) or multiple RSS table
(SR-IOV mode), the table size is different on hardware design.

How could I keep the RSS redirection table during the mode switching?