netdev - RE: [PATCH iwl-next] idpf: remove duplicate defines in IDPF_CAP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <IA1PR11MB628982EEB7B455EE7E96538B8911A@IA1PR11MB6289.namprd11.prod.outlook.com>
Date: Fri, 19 Sep 2025 17:36:19 +0000
From: "Joshi, Sreedevi" <sreedevi.joshi@...el.com>
To: "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Loktionov, Aleksandr"
	<aleksandr.loktionov@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>
Subject: RE: [PATCH iwl-next] idpf: remove duplicate defines in IDPF_CAP_RSS

> -----Original Message-----
> From: Joshi, Sreedevi <sreedevi.joshi@...el.com>
> Sent: Friday, September 19, 2025 12:59 PM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: netdev@...r.kernel.org; Joshi, Sreedevi <sreedevi.joshi@...el.com>; Loktionov, Aleksandr <aleksandr.loktionov@...el.com>; Kitszel,
> Przemyslaw <przemyslaw.kitszel@...el.com>
> Subject: [PATCH iwl-next] idpf: remove duplicate defines in IDPF_CAP_RSS
> 
Fixed inline.

> Remove duplicate defines from the OR operation when defining IDPF_CAP_RSS.
> 
> Duplicate definitions were introduced when IDPF_CAP_RSS was originally
> defined and were left behind and went unnoticed during a previous commit
> that renamed them. Review of the original out-of-tree code confirms these
> duplicates were the result of a typing error.
> 
> Remove the duplicates to clean up the code and avoid potential confusion.
> Also verify no other duplicate occurrences of these defines exist
> elsewhere in the codebase.
> 
> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> Signed-off-by: Sreedevi Joshi <sreedevi.joshi@...el.com>
> ---
>  drivers/net/ethernet/intel/idpf/idpf.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/idpf/idpf.h b/drivers/net/ethernet/intel/idpf/idpf.h
> index 0f320a2b92d2..21c50695348c 100644
> --- a/drivers/net/ethernet/intel/idpf/idpf.h
> +++ b/drivers/net/ethernet/intel/idpf/idpf.h
> @@ -732,13 +732,11 @@ static inline bool idpf_is_rdma_cap_ena(struct idpf_adapter *adapter)
>  }
> 
>  #define IDPF_CAP_RSS (\
> -	VIRTCHNL2_FLOW_IPV4_TCP		|\
>  	VIRTCHNL2_FLOW_IPV4_TCP		|\
>  	VIRTCHNL2_FLOW_IPV4_UDP		|\
>  	VIRTCHNL2_FLOW_IPV4_SCTP	|\
>  	VIRTCHNL2_FLOW_IPV4_OTHER	|\
>  	VIRTCHNL2_FLOW_IPV6_TCP		|\
> -	VIRTCHNL2_FLOW_IPV6_TCP		|\
>  	VIRTCHNL2_FLOW_IPV6_UDP		|\
>  	VIRTCHNL2_FLOW_IPV6_SCTP	|\
>  	VIRTCHNL2_FLOW_IPV6_OTHER)
> --
> 2.25.1
Patch is meant for iwl-next. Missed specifying that on the subject line. Fixed now.
Thanks
Sreedevi