netdev - Re: [PATCH v2 0/5] can: esd_usb: Fixes and improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250919-esoteric-zebra-of-glamour-c6807f-mkl@pengutronix.de>
Date: Fri, 19 Sep 2025 19:45:37 +0200
From: Marc Kleine-Budde <mkl@...gutronix.de>
To: Stefan Mätje <stefan.maetje@....eu>
Cc: Vincent Mailhol <mailhol@...nel.org>, 
	Frank Jungclaus <frank.jungclaus@....eu>, linux-can@...r.kernel.org, socketcan@....eu, 
	Simon Horman <horms@...nel.org>, Oliver Hartkopp <socketcan@...tkopp.net>, 
	Wolfgang Grandegger <wg@...ndegger.com>, "David S . Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH v2 0/5] can: esd_usb: Fixes and improvements

On 21.08.2025 16:34:17, Stefan Mätje wrote:
> The first patch fixes a condition where the esd_usb CAN driver
> may not detect connected CAN-USB devices correctly after a
> reboot. This patch was already presented on the list before
> starting this series and changes due to that feedback are
> integrated.
> 
> References:
> https://lore.kernel.org/linux-can/d7fd564775351ea8a60a6ada83a0368a99ea6b19.camel@esd.eu/
> 
> The second patch fixes situations where the the handling of TX
> context objects for each sent CAN frame could go out of sync
> with the acknowledged or erroneous TX jobs and then lose free
> TX context objects. This could lead to the driver incapable of
> sending frames.
> 
> The third patch adds TX FIFO watermark to eliminate occasional
> error messages and significantly reduce the number of calls to
> netif_start_queue() and netif_stop_queue().

Applied patches 1...3 to linux-can as these are fixes.

Thank you for the very detailed description of the patches, I really
appreciate this! While applying I've changed some sentences to more
imperative wording, e.g. "Moved the code" -> "Move the code".

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)